site: Fix rolling releases page - #30657
Closed
armandomontanez wants to merge 3 commits into
Closed
Conversation
armandomontanez
marked this pull request as ready for review
August 10, 2026 21:43
github-actions
Bot
added
the
awaiting-review
Contributor
Author
|
The mixed dark/light mode looks bad, but at least the page loads with this. |
|
✅ Bazel docs preview is ready! Preview URL: https://bazel-pr-30657.mintlify.app/ Updated for |
fweikert
self-requested a review
August 11, 2026 12:42
fweikert
approved these changes
Aug 11, 2026
5 tasks
copybara-service Bot
pushed a commit
that referenced
this pull request
Aug 17, 2026
#30702) ## Summary Mintlify renders hand-authored MDX as JSX. HTML-style `style="property: value"` attributes are not valid in MDX and cause pages to fail with HTTP 500 errors or be silently excluded from the site build. This change converts all inline `style="..."` attributes to JSX object form `style={{...}}`, with CSS property names in camelCase and values as strings—matching the approach in #30657. **Root cause:** MDX expects JSX-style objects for inline styles, not HTML string attributes. **Example (from `docs/release/rolling.mdx`):** Before: ```html <iframe src="..." style="height: 3000px; width: 100%" /> ``` After: ```jsx <iframe src="..." style={{height: "3000px", width: "100%", border: "none"}} /> ``` ## Affected pages (unversioned + all `docs/versions/*/` copies) - `docs/configure/attributes.mdx` - `docs/docs/configurable-attributes.mdx` - `docs/release/rolling.mdx` - `docs/external/mod-command.mdx` - `docs/external/migration_tool.mdx` - `docs/contribute/search.mdx` **66 files** updated (6 top-level pages + versioned mirrors where those paths exist). ## Proof (post-fix excerpts) `docs/release/rolling.mdx`: ```jsx <iframe src="https://releases.bazel.build/rolling.html" style={{height: "3000px", width: "100%", border: "none"}} ></iframe> ``` `docs/configure/attributes.mdx`: ```jsx <tr style={{background: "#E9E9E9", fontWeight: "bold"}}> ``` Fixes #30658 Fixes #30668 ## Test plan ### Unit / build - [x] No remaining `style="` in targeted `.mdx` paths (verified by conversion script) ### Mintlify preview Preview: https://bazel-pr-30702.mintlify.app/ | Page | Before (production) | Preview check | |------|---------------------|---------------| | `/configure/attributes` | HTTP 500 (#30668) | [ ] HTTP 200, styled table renders | | `/release/rolling` | excluded from build (#30658) | [ ] iframe loads rolling releases index | | `/external/mod-command` | excluded | [ ] side-by-side SVG layout renders | | `/external/migration_tool` | excluded | [ ] flex-wrap diagram layout renders | | `/contribute/search` | excluded | [ ] filter reference table renders | | `/docs/configurable-attributes` | excluded | [ ] styled table renders | - [x] Preview deployed (bazel-docs bot comment) - [x] `/configure/attributes` — HTTP 200, Playwright screenshot captured - [x] `/release/rolling` — HTTP 200, Playwright screenshot captured - [ ] Remaining pages spot-checked in preview Closes #30702. PiperOrigin-RevId: 966209949 Change-Id: Ieb8c1d6db75561df20a4737e4ea35000deb99937
iancha1992
added
team-Documentation
Contributor
Author
|
Fixed by Alex's PR |
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the broken https://bazel.build/release/rolling page.
RELNOTES: None