Skip to content

bison@3.8.2.bcr.6 - #9320

Merged
UebelAndre merged 1 commit into
bazelbuild:mainfrom
UebelAndre:bison
Jun 17, 2026
Merged

bison@3.8.2.bcr.6#9320
UebelAndre merged 1 commit into
bazelbuild:mainfrom
UebelAndre:bison

Conversation

@UebelAndre

@UebelAndre UebelAndre commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@bazel-io

bazel-io commented Jun 16, 2026

Copy link
Copy Markdown
Member

Hello BCR maintainers, modules (bison) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@bazel-io
bazel-io requested review from a team, fweikert and keith and removed request for a team June 16, 2026 23:55
@UebelAndre

UebelAndre commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

relates to chipsalliance/verible#2524 (comment)

bazel-io
bazel-io previously approved these changes Jun 17, 2026
View reviewed changes

@bazel-io bazel-io left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@bazel-io bazel-io added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Jun 17, 2026
@hzeller

hzeller commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Thanks for working on expanding the compatibility!

@bazel-io
bazel-io dismissed their stale review June 17, 2026 15:59

Require module maintainers' approval for newly pushed changes.

bazel-io
bazel-io approved these changes Jun 17, 2026
View reviewed changes

@bazel-io bazel-io left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@UebelAndre
UebelAndre merged commit c3db84f into bazelbuild:main Jun 17, 2026
32 checks passed
@UebelAndre

UebelAndre commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

@hzeller let me know if this version works for you!

@hzeller

hzeller commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Looks better -- no problem with the headers -- but still not fully cured.
https://github.com/chipsalliance/verible/actions/runs/27709358157/job/81966110155?pr=2524#step:7:18

Now, implicit function declarations for strverscmp(), gettimeofday() and getrusage() are an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bazel-io bazel-io bazel-io approved these changes
@keith keith Awaiting requested review from keith keith was automatically assigned from bazelbuild/bcr-maintainers
@fweikert fweikert Awaiting requested review from fweikert fweikert was automatically assigned from bazelbuild/bcr-maintainers

Assignees

No one assigned

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@UebelAndre @bazel-io @hzeller