fix(pypi): append .bat extension for rewritten shebang scripts in RECORD on Windows - #4114
Merged
Merged
Conversation
Convert importlib_metadata_test from unittest to pytest and use the pytest_test rule. Also update assertions to expect .bat extensions for rewritten shebang scripts on Windows and verify all located files directly.
Configure python_versions to test importlib_metadata_test across Python 3.10 through 3.14.
…cord_rewriter_test Update Windows RECORD expected output in wheel_record_rewriter_test so that .sh scripts without Python shebangs do not expect a .bat extension.
Configure target_compatible_with = SUPPORTS_BZLMOD for importlib_metadata_test since pytest_test dependencies require bzlmod.
…dows in RECORD files On Windows, shebang-bin scripts are rewritten to .bat wrappers. Update wheel RECORD rewriters to append .bat for extensionless script entries.
During wheel RECORD generation on Windows, .bat should only be appended to scripts that underwent shebang rewriting (those with #!python), rather than all extensionless scripts. Pass the list of rewritten scripts from whl_library_srcs to gen_wheel_record and selectively append .bat in the rewriter.
rickeylev
marked this pull request as ready for review
August 27, 2026 08:09
rickeylev
enabled auto-merge
August 27, 2026 08:10
rickeylev
changed the title
aignas
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, wheel scripts with Python shebangs are rewritten as .bat
wrappers, but the generated RECORD file retained extensionless script
paths. This caused importlib.metadata file resolution and RECORD
verification to fail when locating installed scripts.
Pass the list of rewritten scripts from whl_library_srcs to
gen_wheel_record and update the RECORD rewriters to append .bat only to
those rewritten script entries on Windows.
and add Windows .bat verification.