doc_tests: run on Python 3.14 and regenerate notebooks#990
Merged
Conversation
Move the doc_tests CI job from Python 3.10 to 3.14 so the notebook regeneration tests run on the same interpreter as the rest of the matrix. build_docs and readthedocs_build stay on 3.10 (the latter must match ReadTheDocs' environment). Regenerate the checked-in notebooks against current batfish. vxlan_evpn picks up the renamed evpnL3VniProperties columns (Import_Route_Target/Export_Route_Target -> plural *_Route_Targets, now List of str) from batfish/batfish#10117. The remaining notebook diffs are the newer pandas' HTML output (non-breaking spaces, an added mathjax_ignore table class) and the kernel version metadata bump, which match what the 3.14 job now produces. ---- Prompt: ``` Let's swap github CI to use 3.14 for doc tests, then replace all the notebooks with the new ones ```
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #990 +/- ##
=======================================
Coverage 86.58% 86.58%
=======================================
Files 26 26
Lines 3906 3906
Branches 527 527
=======================================
Hits 3382 3382
Misses 364 364
Partials 160 160 🚀 New features to boost your workflow:
|
dhalperi
commented
Jul 24, 2026
dhalperi
left a comment
Member
Author
There was a problem hiding this comment.
@dhalperi reviewed 13 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on dhalperi).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the doc_tests CI job from Python 3.10 to 3.14 so the notebook
regeneration tests run on the same interpreter as the rest of the
matrix. build_docs and readthedocs_build stay on 3.10 (the latter must
match ReadTheDocs' environment).
Regenerate the checked-in notebooks against current batfish. vxlan_evpn
picks up the renamed evpnL3VniProperties columns
(Import_Route_Target/Export_Route_Target -> plural *_Route_Targets, now
List of str) from batfish/batfish#10117. The remaining notebook diffs
are the newer pandas' HTML output (non-breaking spaces, an added
mathjax_ignore table class) and the kernel version metadata bump, which
match what the 3.14 job now produces.
Prompt: