Skip to content

Store only key-value pairs in Hash arrays #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Store only key-value pairs in Hash arrays #1341

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
771f421
Store only key-value pairs in Hash arrays
OskarEichler Aug 30, 2026
b18896b
Test Hash toArray key-value pairs
OskarEichler Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion action_text-trix/app/assets/javascripts/trix.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1397,7 +1397,7 @@ $\
const result = [];
for (const key in this.values) {
const value = this.values[key];
result.push(result.push(key, value));
result.push(key, value);
}
this.array = result.slice(0);
}
Expand Down
2 changes: 1 addition & 1 deletion src/trix/core/collections/hash.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export default class Hash extends TrixObject {
const result = []
for (const key in this.values) {
const value = this.values[key]
result.push(result.push(key, value))
result.push(key, value)
}
this.array = result.slice(0)
}
Expand Down