Skip to content

Only ensure the run directory on the primary host #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andyjeffries wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Only ensure the run directory on the primary host #1908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/kamal/cli/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ def reset_invocation(cli_class)
end

def ensure_run_directory
on(KAMAL.hosts) do
on(KAMAL.primary_host) do
execute(*KAMAL.server.ensure_run_directory)
end
end
Expand Down
9 changes: 9 additions & 0 deletions test/cli/lock_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,15 @@ class CliLockTest < CliTestCase
end
end

test "acquire ensures the run directory only on the primary host" do
run_command("acquire", "-m", "hello").tap do |output|
assert_match "Running /usr/bin/env mkdir -p .kamal on 1.1.1.1", output
assert_no_match(/mkdir -p \.kamal on 1\.1\.1\.2/, output)
assert_no_match(/mkdir -p \.kamal on 1\.1\.1\.3/, output)
assert_no_match(/mkdir -p \.kamal on 1\.1\.1\.4/, output)
end
end

test "status when there is no deploy lock" do
SSHKit::Backend::Abstract.any_instance.stubs(:capture_with_debug)
.raises(RuntimeError, "cat: .kamal/lock-app/details: No such file or directory")
Expand Down