Skip to content

chore(L1): remove EthLockbox#378

Merged
jackchuma merged 2 commits into
mainfrom
chore/remove-ethlockbox
Jul 20, 2026
Merged

chore(L1): remove EthLockbox#378
jackchuma merged 2 commits into
mainfrom
chore/remove-ethlockbox

Conversation

@jackchuma

Copy link
Copy Markdown
Contributor

What changed? Why?

Removed the unused EthLockbox contract and all of its integration points. OptimismPortal2 now keeps ETH directly, while retaining the former storage slot as a generic spacer for upgrade compatibility.

Notes to reviewers

  • Removes EthLockbox deployment artifacts, feature-flag handling, portal calls, tests, and snapshots.
  • Updates portal and bridge custody assertions to expect ETH to remain in OptimismPortal2.

How has it been tested?

  • forge build --skip "/**/test/**" --skip "/**/scripts/**"
  • forge test --match-path test/L1/OptimismPortal2.t.sol
  • forge test --match-path test/L1/L1StandardBridge.t.sol
  • forge test --match-path test/L1/SystemConfig.t.sol
  • forge test --match-path test/deploy/SystemDeploy.t.sol
  • forge test --match-path test/vendor/Initializable.t.sol

Co-authored-by: Codex <codex-noreply@coinbase.com>
@cb-heimdall

cb-heimdall commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Comment thread test/L1/OptimismPortal2.t.sol
Co-authored-by: Codex <codex-noreply@coinbase.com>
@jackchuma
jackchuma requested a review from leopoldjoy July 20, 2026 21:00
@jackchuma
jackchuma merged commit 6c530ef into main Jul 20, 2026
6 checks passed
@jackchuma
jackchuma deleted the chore/remove-ethlockbox branch July 20, 2026 21:48
@cb-heimdall

Copy link
Copy Markdown
Collaborator

Review Error for CatfishbillyIII @ 2026-07-21 18:31:00 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants