Conversation
aethernet
force-pushed
the
aethernet/report-secureboot-status
branch
2 times, most recently
from
March 18, 2025 16:22
8ba6abd to
9b22c71
Compare
This was referenced Mar 19, 2025
aethernet
force-pushed
the
aethernet/report-secureboot-status
branch
from
March 20, 2025 13:10
9b22c71 to
dcc1ab0
Compare
Page-
reviewed
Mar 20, 2025
Comment on lines
+52
to
+54
| is_secureboot_enabled?: boolean; | ||
| is_storage_encrypted?: boolean; | ||
| secureboot_keys_metadata?: string | null; |
Contributor
There was a problem hiding this comment.
State-patch v2 will never report these props:
Suggested change
| is_secureboot_enabled?: boolean; | |
| is_storage_encrypted?: boolean; | |
| secureboot_keys_metadata?: string | null; |
| Concept Type: Integer (Type) | ||
|
|
||
| Term= secureboot keys metadata | ||
| Concept Type: Short Text (Type) |
Contributor
There was a problem hiding this comment.
Suggested change
| Concept Type: Short Text (Type) | |
| Concept Type: JSON (Type) |
| @@ -0,0 +1,3 @@ | |||
| ALTER TABLE "device" ADD COLUMN IF NOT EXISTS "is secureboot enabled" BOOLEAN NULL; | |||
| ALTER TABLE "device" ADD COLUMN IF NOT EXISTS "is storage encrypted" BOOLEAN NULL; | |||
| ALTER TABLE "device" ADD COLUMN IF NOT EXISTS "secureboot keys metadata" JSONB NULL; No newline at end of file | |||
Contributor
There was a problem hiding this comment.
This doesn't actually match the generated schema from the sbvr so this would be an invalid migration, it's better to fix at the sbvr level but it's worth noting that you can generate the schema via npm run generate-model-schema and make sure the column types match
| Term: memory total | ||
| Concept Type: Integer (Type) | ||
|
|
||
| Term= secureboot keys metadata |
Contributor
There was a problem hiding this comment.
Personally I wouldn't expose this on v6, if it's info people want then they can update to using v7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://balena.fibery.io/Work/Improvement/Spec-for-Supervisor-+-API-changes-2388
related-to: