Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azalea dropped any container packet that contained an item with can_break or can_place_on because the BlockPredicate codec was not updated to match the vanilla changes in 1.21.5.
BlockStateValueMatcher was being read as a varint, but vanilla now sends it as an Either using a bool (true for exact, false for range). This caused exact matchers to be read as ranges, so the value string's length ended up being read as the "has min" bool, breaking everything after it.
BlockPredicate was also missing the component matchers added in 1.21.5 after the nbt field (exact components and partial predicates). Partial predicates use fromCodecWithRegistries, so the value is just an NBT tag.
Since the whole packet failed to read, any GUI would also show up empty if the player had one of these items in their inventory, because ContainerSetContent includes the player's inventory slots.
Seen with a hoe that has can_break for wheat/carrots/potatoes at age=7: