Skip to content

Daily Sync with Botocore v1.43.88 on 2026/09/04 - #6239

Open
sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-04-10-06-52
Open

Daily Sync with Botocore v1.43.88 on 2026/09/04#6239
sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-04-10-06-52

Conversation

@sagemaker-bot

Copy link
Copy Markdown
Collaborator

Daily sync with Botocore package. This PR is automatically generated by sagemaker-bot.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Claude finished @sagemaker-bot's task in 1m 51s —— View job


PR Review: Daily Botocore Sync (v1.43.88)

  • Read the full PR diff (/tmp/pr.diff)
  • Analyze the generated Python changes for correctness / backward-compat
  • Check for security, best-practice, and test concerns
  • Post review

This is an auto-generated daily sync of the botocore service models plus the regenerated sagemaker-core code (shapes.py, resources.py, config_schema.py, shape_dag.py, api_coverage.json). The changes are consistent across all four generated artifacts — every new shape appears in shapes.py, shape_dag.py, and the resource method signatures together, which is what a correct regeneration should look like. Nothing is hand-edited.

Overall: looks clean. No logic was hand-written; the additive changes (LoRA adapter sources for AI recommendation jobs, ContainerMetricsConfig/EnableDetailedObservability, prefix-aware routing, HyperPod auto-patch config, IdcConfig for Partner AI Apps, MLflow kms_key_id, feature-store Standard_V2 + UpdateRecord, new instance types, etc.) are all optional and backward-compatible.

One thing worth flagging (not a defect, just a heads-up for consumers)

Endpoint.invoke_async(...) in resources.py had a signature change driven by the upstream model: input_location went from a required first positional argument to an optional keyword argument, and it now sits after inference_id in the parameter list (a new inline body payload was added as a mutually-exclusive alternative to InputLocation, so the service no longer marks InputLocation as required).

# before
def invoke_async(self, input_location: StrPipeVar, content_type=..., ...)
# after
def invoke_async(self, content_type=..., accept=..., custom_attributes=..., inference_id=...,
                 input_location=Unassigned(), ..., body=Unassigned(), ...)

Any caller passing the S3 URI positionally (endpoint.invoke_async("s3://...")) would now bind it to content_type instead of input_location. Callers using the keyword form (input_location=...) are unaffected. This faithfully mirrors the botocore service-2.json change (InvokeEndpointAsyncInput.required dropped InputLocation), so there's nothing to fix here — noting it only because the sync silently reorders a public positional parameter.

Minor / cosmetic (no action needed)

  • The regenerated ConflictException in shapes.py carries the generic docstring ("…a conflict when you attempted to modify a SageMaker entity such as an Experiment or Artifact") rather than the feature-store-runtime EventTime-conflict text from the new model. This is the usual shared-shape-name dedupe behavior of the generator, not a functional issue.
  • ProcessingClusterConfig reorders volume_size_in_gb to be the first (now sole required) field with instance_count/instance_type becoming optional — matches the model's required change and is safe for the keyword-constructed Base classes.

No security concerns (docstring/model-only changes; no credential or input-validation logic touched). Tests aren't included, which is expected for these generated sync PRs.
· branch botocore-sync-2026-09-04-10-06-52

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.93%. Comparing base (55c2a9b) to head (6af170b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6239      +/-   ##
==========================================
+ Coverage   62.00%   70.93%   +8.92%     
==========================================
  Files         553      553              
  Lines       68029    68113      +84     
==========================================
+ Hits        42184    48317    +6133     
+ Misses      25845    19796    -6049     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant