Skip to content

Put the advanced connection settings behind a disclosure - #2278

Merged
kmcginnes merged 1 commit into
mainfrom
edge-stack/3-advanced-connection-options
Sep 26, 2026
Merged

kmcginnes merged 1 commit into
mainfrom
edge-stack/3-advanced-connection-options

Conversation

@kmcginnes

@kmcginnes kmcginnes commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Description

  • Fetch Timeout and Neighbor Expansion Limit move into a collapsible "Advanced options" section of the connection dialog, so the common fields aren't buried.
  • The section opens by itself when the connection already overrides one of them, so an existing override is never hidden.
  • The trigger is a real button, so it works from the keyboard and announces whether it's expanded.
  • The Fetch Timeout error message and the troubleshooting guide now point at the connection's advanced options.

Validation

  • Tests that the section starts collapsed, expands on click, and opens itself for a connection with a Fetch Timeout override.
  • pnpm checks and pnpm test clean on this layer.

Screenshots

A new connection starts with the advanced options collapsed.

New connection dialog with Advanced options collapsed

Expanding them shows Fetch Timeout and Neighbor Expansion Limit.

Advanced options expanded, showing Enable Fetch Timeout and Override Default Neighbor Expansion Limit

Editing a connection that already sets a Fetch Timeout opens the section by itself.

Editing a connection with a 30000 ms fetch timeout, with Advanced options already open

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I have verified pnpm checks passes with no errors.
  • I have verified pnpm test passes with no failures.
  • I have covered new added functionality with unit tests if necessary.
  • I have updated documentation if necessary.

@kmcginnes
kmcginnes marked this pull request as ready for review September 25, 2026 22:25
@kmcginnes
kmcginnes added this pull request to stack #2283 September 25, 2026 22:25
kmcginnes added a commit that referenced this pull request Sep 25, 2026
## Description

- `mapWithConcurrency` rejected on the first failure, but its other
lanes kept looping and sending requests nobody was waiting for. The
first rejection now stops the pool from starting new work. Callbacks
already running aren't cancelled.
- This also affects openCypher and SPARQL schema and edge connection
fetches, which used to drain the whole queue after a failure.
- Later in the stack, edge connection discovery relies on this, so
abandoning an attempt actually stops it.

## Validation

- New test: after one callback rejects, no further callbacks start.
- `pnpm checks` and `pnpm test` clean on this layer.

## Related Issues

- Part of #2141 (split out of #2244)
- Layer 1 of 6. Stack, bottom first: #2281 → #2277 → #2278 → #2279 →
#2280 → #2282

### Check List

- [x] I confirm that my contribution is made under the terms of the
Apache 2.0 license.
- [x] I have verified `pnpm checks` passes with no errors.
- [x] I have verified `pnpm test` passes with no failures.
- [x] I have covered new added functionality with unit tests if
necessary.
- [x] I have updated documentation if necessary.
kmcginnes added a commit that referenced this pull request Sep 25, 2026
## Description

- `mapWithConcurrency` rejected on the first failure, but its other
lanes kept looping and sending requests nobody was waiting for. The
first rejection now stops the pool from starting new work. Callbacks
already running aren't cancelled.
- This also affects openCypher and SPARQL schema and edge connection
fetches, which used to drain the whole queue after a failure.
- Later in the stack, edge connection discovery relies on this, so
abandoning an attempt actually stops it.

## Validation

- New test: after one callback rejects, no further callbacks start.
- `pnpm checks` and `pnpm test` clean on this layer.

## Related Issues

- Part of #2141 (split out of #2244)
- Layer 1 of 6. Stack, bottom first: #2281 → #2277 → #2278 → #2279 →
#2280 → #2282

### Check List

- [x] I confirm that my contribution is made under the terms of the
Apache 2.0 license.
- [x] I have verified `pnpm checks` passes with no errors.
- [x] I have verified `pnpm test` passes with no failures.
- [x] I have covered new added functionality with unit tests if
necessary.
- [x] I have updated documentation if necessary.
@kmcginnes
kmcginnes force-pushed the edge-stack/3-advanced-connection-options branch from e252723 to 6b8d352 Compare September 25, 2026 22:46
@kmcginnes
kmcginnes force-pushed the edge-stack/3-advanced-connection-options branch 3 times, most recently from e070416 to fd92386 Compare September 25, 2026 23:40

@kmcginnes kmcginnes left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@kmcginnes
kmcginnes force-pushed the edge-stack/3-advanced-connection-options branch from fd92386 to cffbc5d Compare September 26, 2026 17:48
@kmcginnes
kmcginnes force-pushed the edge-stack/3-advanced-connection-options branch from cffbc5d to 3c69c00 Compare September 26, 2026 21:57
@kmcginnes
kmcginnes removed this pull request from stack #2283 September 26, 2026 23:14
@kmcginnes
kmcginnes changed the base branch from edge-stack/2-schema-view-without-edge-connections to main September 26, 2026 23:14
@kmcginnes
kmcginnes force-pushed the edge-stack/3-advanced-connection-options branch from 3c69c00 to 719624a Compare September 26, 2026 23:15
@kmcginnes
kmcginnes added this pull request to stack #2289 September 26, 2026 23:15
@kmcginnes
kmcginnes merged commit 49f4933 into main Sep 26, 2026
10 checks passed
@kmcginnes
kmcginnes deleted the edge-stack/3-advanced-connection-options branch September 26, 2026 23:19
kmcginnes added a commit that referenced this pull request Sep 27, 2026
Squashes the reviewed pre-split history of #1773 onto main after #2278.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant