Routine tests - auxiliary fixes - #6337
Conversation
The no-commit-to-branch is intended to prevent developers from committing directly to master. Scheduled workflows legitimately run from master, so it should not participate in CI static checks. Signed-off-by: Plamen Dimitrov <plamen.dimitrov@intra2net.com>
It seems a few workflows and jobs were still missed in previous fixed and only my own testing from my own fork passed. Signed-off-by: Plamen Dimitrov <plamen.dimitrov@intra2net.com>
Make weekly TestPyPI builds meaningful by assigning a unique development version before building to avoid "File already exists" messages. Signed-off-by: Plamen Dimitrov <plamen.dimitrov@intra2net.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
WalkthroughThe CI workflows now set Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@harvey0100 The "push to test PyPI" job will not pass unless additional permissions are set on the PyPI side. Either you must authorize the exact project |
|
@PraveenPenguin I noticed your |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6337 +/- ##
==========================================
- Coverage 71.74% 71.74% -0.01%
==========================================
Files 207 207
Lines 23624 23624
==========================================
- Hits 16949 16948 -1
- Misses 6675 6676 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Actually I managed by swapping HTTPS for SSH. Will do the manual testing now. |
|
Ok, manual tests passed with the exception of one conditional job based on |
@richtja can you please help here |
|
It could be that @richtja will not reply for weeks if not longer and these tests are triggered and failing weekly. So we might as well merge this (see my manual testing results above) and double check everything automatically next week once the scheduled workflows execute. @PraveenPenguin Thoughts? |
yes sure make sense. We can wait for some time for @richtja , otherwise, we can merge. Even we need his help how to enable one of us if he is not active in this repo, may @harvey0100 is right person to have ACL |
My manual testing passed by could not cover all events that would happen when these workflows are invoked from within the avocado project's master branch. After debugging the scheduled test results for this week hopefully these changes will make them pass for real.
Summary by CodeRabbit