Skip to content

Routine tests - auxiliary fixes - #6337

Open
pevogam wants to merge 3 commits into
avocado-framework:masterfrom
pevogam:routine-tests-aux-fixes
Open

Routine tests - auxiliary fixes#6337
pevogam wants to merge 3 commits into
avocado-framework:masterfrom
pevogam:routine-tests-aux-fixes

Conversation

@pevogam

@pevogam pevogam commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

My manual testing passed by could not cover all events that would happen when these workflows are invoked from within the avocado project's master branch. After debugging the scheduled test results for this week hopefully these changes will make them pass for real.

Summary by CodeRabbit

  • Chores
    • Improved automated pre-release and weekly build workflows for more reliable package creation and setup.
    • Pre-release builds now receive unique weekly development versions, making them easier to identify and track.
    • Updated environment setup steps to improve compatibility during automated installations.
    • Standardized workflow behavior to avoid unnecessary commit-related checks during automation.

pevogam added 3 commits August 4, 2026 18:11
The no-commit-to-branch is intended to prevent developers from
committing directly to master. Scheduled workflows legitimately run
from master, so it should not participate in CI static checks.

Signed-off-by: Plamen Dimitrov <plamen.dimitrov@intra2net.com>
It seems a few workflows and jobs were still missed in previous
fixed and only my own testing from my own fork passed.

Signed-off-by: Plamen Dimitrov <plamen.dimitrov@intra2net.com>
Make weekly TestPyPI builds meaningful by assigning a unique
development version before building to avoid "File already exists"
messages.

Signed-off-by: Plamen Dimitrov <plamen.dimitrov@intra2net.com>
@pevogam pevogam self-assigned this Aug 4, 2026
@mr-avocado mr-avocado Bot moved this to Review Requested in Default project Aug 4, 2026
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f2af5e14-aa81-43a4-a495-89c2045fce02

📥 Commits

Reviewing files that changed from the base of the PR and between a02d1ea and e8bc6d2.

📒 Files selected for processing (3)
  • .github/workflows/prerelease.yml
  • .github/workflows/setup.yml
  • .github/workflows/weekly.yml

Walkthrough

The CI workflows now set SKIP=no-commit-to-branch. The prerelease and weekly workflows upgrade setuptools before development installation. The prerelease workflow also generates a .dev package version from VERSION and the workflow run number before building artifacts.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes auxiliary fixes to routine tests, which matches the primary purpose of the workflow changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pevogam

pevogam commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator Author

@harvey0100 The "push to test PyPI" job will not pass unless additional permissions are set on the PyPI side. Either you must authorize the exact project avocado-framework-plugin-result-mail or give me access so I can authorize it. Until that point this workflow will keep failing and these changes only improve non-fatal errors about already existing files.

@pevogam

pevogam commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator Author

@PraveenPenguin I noticed your ymallfix branch was pushed directly to the core repo, is this truly possible for me to do the same with a mirror of this branch? Because I could not push a non-master branch to the core repo so far and thus test these changes anywhere but on my own fork.

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.74%. Comparing base (a02d1ea) to head (e8bc6d2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6337      +/-   ##
==========================================
- Coverage   71.74%   71.74%   -0.01%     
==========================================
  Files         207      207              
  Lines       23624    23624              
==========================================
- Hits        16949    16948       -1     
- Misses       6675     6676       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pevogam

pevogam commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator Author

Actually I managed by swapping HTTPS for SSH. Will do the manual testing now.

@pevogam

pevogam commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator Author

Ok, manual tests passed with the exception of one conditional job based on if: ${{ github.repository == 'avocado-framework/avocado' && always() && needs.latest-python.outputs.job_status == 'failure' }} that I could not trigger manually and the PyPI limitations mentioned above.

@PraveenPenguin

Copy link
Copy Markdown
Member

@harvey0100 The "push to test PyPI" job will not pass unless additional permissions are set on the PyPI side. Either you must authorize the exact project avocado-framework-plugin-result-mail or give me access so I can authorize it. Until that point this workflow will keep failing and these changes only improve non-fatal errors about already existing files.

@richtja can you please help here

@pevogam

pevogam commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator Author

It could be that @richtja will not reply for weeks if not longer and these tests are triggered and failing weekly. So we might as well merge this (see my manual testing results above) and double check everything automatically next week once the scheduled workflows execute. @PraveenPenguin Thoughts?

@PraveenPenguin

Copy link
Copy Markdown
Member

It could be that @richtja will not reply for weeks if not longer and these tests are triggered and failing weekly. So we might as well merge this (see my manual testing results above) and double check everything automatically next week once the scheduled workflows execute. @PraveenPenguin Thoughts?

yes sure make sense. We can wait for some time for @richtja , otherwise, we can merge. Even we need his help how to enable one of us if he is not active in this repo, may @harvey0100 is right person to have ACL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review Requested

Development

Successfully merging this pull request may close these issues.

2 participants