add lkp helper for Intel LKP - #6314
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new utility module avocado/utils/lkp.py to drive Intel LKP (lkp-tests) microbenchmarks. The feedback highlights several critical issues: potential localization failures in the tolerant apt installer script, incorrect execution of chained commands under sudo when using shell execution, missing sudo support in install_job for dependency installation, potential OSError exceptions when sorting files by modification time, and a failure in archive_results if the destination path exists as a file or symlink instead of a directory.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
8436d59 to
0742935
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6314 +/- ##
==========================================
- Coverage 71.69% 71.34% -0.36%
==========================================
Files 206 207 +1
Lines 23480 23594 +114
==========================================
- Hits 16834 16833 -1
- Misses 6646 6761 +115 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Add framework-independent helpers to clone, install, split/install a job, and run lkp-tests microbenchmarks locally, plus helpers to locate and archive the result artifacts a run produces. Signed-off-by: Sumit Kumar <sumitkum@amd.com> Co-authored-by: Cursor <cursoragent@cursor.com>
0742935 to
12386ea
Compare
|
Hi @Sumitupadhyay1, this pull requests seems to narrowly specialized to me to be merged into the generic avocado.utils. |
Thanks @pevogam. avocado.utils already includes several single-tool/subsystem wrappers (e.g. nvme.py, multipath.py, softwareraid.py, pmem.py, iso9660.py, cloudinit.py, podman.py, gdb.py), so lkp.py follows an established pattern. |
|
Hmmm I see. We could always ask for the opinions of more people here. In the meantime I would still recommend that if you strongly believe this PR is contributable that you push a pull request to |
Thank. I'd also be open to contributing this additionally to avocado-framework/aautils. My main question is about the intended usage model: how and when are tests expected to consume this functionality from aautils? Right now, we are using utils from avocado only. Can you help with the documentation for tests consuming these utils from aautils ? |
|
The simple answer is: always. The avocado core is no longer meant to contain any but the most substantial utilities and the "batteries" are essentially all meant to be moved there. As such merging pull request like this one will only introduce technical debt due to the need of future migration. |
Thanks for the clarification. That makes sense, and I'm happy to move lkp.py to aautils to avoid future migration work. |
|
I think you know best the specific use cases for this utility and thus can fit it in a proper category there best. |
As discussed, I've opened a Pull Request to aautils as well: Please help me to get it reviewed and merged. |
|
Reviewed and merged, I suggest that we keep this new functionality there instead of having to introduce it and right after that deprecate it here. Are you ok with that? |
Add framework-independent Intel LKP helper utilities
Add a set of framework-independent utilities that simplify working with Intel LKP locally, including helpers to: