remove hardcoded NumberOfPasswordPrompts=1 - #6313
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the 'NumberOfPasswordPrompts' configuration option (previously set to '1') from the SSH master connection setup in avocado/utils/ssh.py. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Before patch : After patch |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6313 +/- ##
==========================================
- Coverage 71.74% 71.73% -0.01%
==========================================
Files 207 207
Lines 23544 23544
==========================================
- Hits 16892 16890 -2
- Misses 6652 6654 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi @vaishnavibhat, this looks very reasonable. Have you tried rebasing to the most current master branch and pushing again so that we can see if the rawhide variant would not fail any longer? |
…ndabot/github_actions/actions/setup-python-7 build(deps): bump actions/setup-python from 6 to 7
Hi @pevogam |
|
The changes looks good and thanks for rebasing but please address the failing static checks first. |
The previously hardcoded value of 1 caused connection failures on networks with transient delays, as SSH would give up after a single failed password exchange attempt with no retries.
Removing this option defers to SSH's built-in default of 3, allowing the authentication phase to be retried on slow or jittery networks without hardcoding a specific value that may not suit all environments.