Skip to content

remove hardcoded NumberOfPasswordPrompts=1 - #6313

Open
vaishnavibhat wants to merge 1 commit into
avocado-framework:masterfrom
vaishnavibhat:ssh_retry
Open

remove hardcoded NumberOfPasswordPrompts=1#6313
vaishnavibhat wants to merge 1 commit into
avocado-framework:masterfrom
vaishnavibhat:ssh_retry

Conversation

@vaishnavibhat

Copy link
Copy Markdown
Contributor

The previously hardcoded value of 1 caused connection failures on networks with transient delays, as SSH would give up after a single failed password exchange attempt with no retries.

Removing this option defers to SSH's built-in default of 3, allowing the authentication phase to be retried on slow or jittery networks without hardcoding a specific value that may not suit all environments.

@mr-avocado mr-avocado Bot moved this to Review Requested in Default project Jul 2, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the 'NumberOfPasswordPrompts' configuration option (previously set to '1') from the SSH master connection setup in avocado/utils/ssh.py. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@vaishnavibhat

Copy link
Copy Markdown
Contributor Author

Before patch :
avocado run tcpdump.py -m tcpdump.py.data/tcpdump.yaml --max-parallel-tasks=1
JOB ID : 268c4c43b560770241f1ea5046f2ce1e5965de2d
JOB LOG : /home/OpTest/avocado-fvt-wrapper/results/job-2026-07-02T07.36-268c4c4/job.log
(01/63) tcpdump.py:TcpdumpTest.test;run-mtu-1500-options-generic-a5b9: STARTED
(01/63) tcpdump.py:TcpdumpTest.test;run-mtu-1500-options-generic-a5b9: ERROR: Failed connecting to root@10.48.37.179:22. Ensure credentials are correct and host is reachable. (76.91 s)

After patch
avocado run tcpdump.py -m tcpdump.py.data/tcpdump.yaml --max-parallel-tasks=1
JOB ID : b05d020490f08257c0410c7ec2f3bcdce4577b4e
JOB LOG : /home/OpTest/avocado-fvt-wrapper/results/job-2026-07-02T08.30-b05d020/job.log
(01/63) tcpdump.py:TcpdumpTest.test;run-mtu-1500-options-generic-a5b9: STARTED
(01/63) tcpdump.py:TcpdumpTest.test;run-mtu-1500-options-generic-a5b9: PASS (135.34 s)

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.73%. Comparing base (3398fde) to head (5aa13fd).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6313      +/-   ##
==========================================
- Coverage   71.74%   71.73%   -0.01%     
==========================================
  Files         207      207              
  Lines       23544    23544              
==========================================
- Hits        16892    16890       -2     
- Misses       6652     6654       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pevogam

pevogam commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Hi @vaishnavibhat, this looks very reasonable. Have you tried rebasing to the most current master branch and pushing again so that we can see if the rawhide variant would not fail any longer?

@pevogam pevogam self-assigned this Jul 9, 2026
…ndabot/github_actions/actions/setup-python-7

build(deps): bump actions/setup-python from 6 to 7
@vaishnavibhat

Copy link
Copy Markdown
Contributor Author

Hi @vaishnavibhat, this looks very reasonable. Have you tried rebasing to the most current master branch and pushing again so that we can see if the rawhide variant would not fail any longer?

Hi @pevogam
I have re pushed the code with the latest master branch.
Thanks for reviewing this.

@pevogam

pevogam commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

The changes looks good and thanks for rebasing but please address the failing static checks first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review Requested

Development

Successfully merging this pull request may close these issues.

2 participants