Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches CI from
pull_request_targettopull_request.pull_request_targetrequired apermission_checkjob plus asafe to testlabel to decide whether a PR's code should run, and every job needed a duplicate checkout step to pick up the PR head. Withpull_requestthe trigger itself scopes what runs, so all of that goes away.Fork PRs can't obtain the CI credentials, so the AWS-touching jobs (
test_general_cloud,test_tabular_cloud,test_timeseries_cloud) andbuild_docare gated ongithub.event.pull_request.head.repo.full_name == github.repository. They skip cleanly on forks rather than failing, leaving lint as the only check. Maintainer branches pushed to this repo still get the full run.Changes:
permission_checkjob and thesafe to testlabel handlingCONTRIBUTING.mdandtests/README.mdfor the new processNote for reviewers: if branch protection lists required status checks, it needs updating —
permission_checkno longer exists, and the guarded jobs now report as skipped on fork PRs.