feat: add query plan cache#3219
Draft
jzelinskie wants to merge 1 commit into
Draft
Conversation
Introduces a queryPlanCache that caches parsed schemas and compiled outlines behind singleflight groups, replacing the per-request schema load and outline build in checkPermission, lookupResources, and lookupSubjects query plan paths. Key correctness considerations: - Bypass-sentinel schema hashes (transactions, dev mode, tests) skip both cache and singleflight to avoid coalescing requests that may read from different datastore revisions. - MaxCost accounts for the entryWeight overhead (key string length) so entries are not immediately evicted. - ApplyAdvisor clones CanonicalKeys before mutation so cached outlines are not corrupted by downstream advisor passes.
github-actions
Bot
added
area/api v1
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces a queryPlanCache that caches parsed schemas and compiled outlines behind singleflight
groups, replacing the per-request schema load and outline build in checkPermission, lookupResources, and lookupSubjects query plan paths.
Key correctness considerations:
Testing
Full consistency tests should handle this.
Just a thought now is maybe we'd want metrics on the cache hits for this.