chore: remove dead code (#1719)#3186
Open
ivanauth wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ivanauth
force-pushed
the
fix/issue-1719-remove-dead-code
branch
from
e72f54b to
f600cb0
Compare
Remove four genuinely-unused symbols flagged by `deadcode`, all under internal/ (no external-API impact) and unused by tests: - common.CancelationContextHandler (cancelation.go, deleted) - common.ConnectWithInstrumentation (superseded by ...AndTimeout) - logging.Log() - shared.NewMaxDepthExceededError (a duplicate; the used one lives in internal/dispatch) Scope is intentionally conservative. NOT removed, despite being flagged: - DebugAnalyzeBeforeStatistics — test-only, but required: the datastore StatsTest relies on it to force ANALYZE (the PG harness runs autovacuum=off, so EstimatedRelationshipCount is 0 without it). - pkg/ exported symbols — removing these needs a deprecation cycle. - AsValidationError — a deadcode false positive; used by pkg/schemautil.
ivanauth
force-pushed
the
fix/issue-1719-remove-dead-code
branch
from
eabde15 to
c6731fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes four unused internal symbols flagged by
deadcode. Keeps test-only andpkg/symbols (incl.DebugAnalyzeBeforeStatistics, needed by the datastore StatsTest).Part of #1719.