refactor: cleanup in-progress keys and readvising#3148
Open
barakmich wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
area/tooling
Contributor
Author
|
I probably won't be cleaning this one up, but I wanted to pass on the last things I had in the queue. Take care, y'all 🖖 |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
tstirrat15
force-pushed
the
barakmich/last
branch
from
June 15, 2026 16:50
d7cff90 to
b9b7201
Compare
tstirrat15
force-pushed
the
barakmich/last
branch
from
June 17, 2026 19:05
33f3bec to
379c025
Compare
tstirrat15
force-pushed
the
barakmich/last
branch
from
June 24, 2026 17:08
379c025 to
1c429c8
Compare
tstirrat15
force-pushed
the
barakmich/last
branch
from
June 24, 2026 17:11
1c429c8 to
0933a2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up the now-unneccessary InProgressKeys field in the request proto, as the serialized subplan is now being sent in the proto.
Then, a performance gain, to re-advise on dispatch (perhaps flipping arrows based on local statistics) and also choosing whether to dispatch based on operation (for now, Check benefits the most)
👋