Skip to content

MAST: get_product_urls for Observations - #3639

Open
cpparts wants to merge 2 commits into
astropy:mainfrom
cpparts:mast-obs-get-product-urls
Open

MAST: get_product_urls for Observations#3639
cpparts wants to merge 2 commits into
astropy:mainfrom
cpparts:mast-obs-get-product-urls

Conversation

@cpparts

@cpparts cpparts commented Jul 28, 2026

Copy link
Copy Markdown

Adds a MAST Observation method (get_product_urls) that returns a list of URLs for products without downloading them. This addresses #2850. These changes have been reviewed/guided by @snbianco, and I am looking forward to feedback!

@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.27%. Comparing base (9bfbce7) to head (2532c02).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/mast/observations.py 94.87% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3639      +/-   ##
==========================================
+ Coverage   73.24%   73.27%   +0.03%     
==========================================
  Files         230      230              
  Lines       21299    21327      +28     
==========================================
+ Hits        15601    15628      +27     
- Misses       5698     5699       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz
bsipocz requested a review from snbianco July 29, 2026 04:30
@bsipocz bsipocz added the mast label Jul 29, 2026
@snbianco

Copy link
Copy Markdown
Contributor

Hey Celia! This looks great (I've already reviewed this PR on a different branch in my repository). To get the two failing checks to pass, you need to add an entry to the CHANGES.rst file. Put in under the "Service fixes and enhancements" subheading, and then "mast."

For the docs build, you can find the warning on line 748 of the output. I think in this case, you need to add a second layer of backticks to the text it's highlighting in the function docstring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants