test: move virtual-deps/django rules_python tests out of root MODULE - #1421
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe change moves third-party dependency handling to uv, adds a Django pip hub and pinned wheel override, and introduces a Django project fixture with management, ASGI, WSGI, and version-validation support. ChangesDjango virtual dependency flow
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
✨ Aspect Workflows Tasks📅 Wed Aug 12 20:18:12 UTC 2026 ✅ 39 successful tasks
⏱ Last updated Wed Aug 12 21:40:25 UTC 2026 · 📊 GitHub API quota 640/15,000 (4% used, resets in 33m) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26ac580e30
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| python_version = "3.12", | ||
| requirements_lock = "//virtual-deps/django:requirements.txt", |
There was a problem hiding this comment.
Regenerate the moved requirements lock under Python 3.12
The newly referenced lockfile was copied unchanged from the Python 3.9 root workspace: its header still names Python 3.9 and the old //py/tests/virtual-deps/django:requirements.update target, and it retains the Python-<3.11-only typing-extensions dependency. In this workspace the default toolchain is 3.12, so the compile_pip_requirements validation target generated in virtual-deps/django/BUILD.bazel will produce different output; the aspect test //... invocation in .github/workflows/ci-workflows.yaml therefore fails for the rules-python-interop job. Regenerate this lockfile from its new target using the 3.12 toolchain.
Useful? React with 👍 / 👎.
26ac580 to
33649d5
Compare
py_binary startup benchmark
sys.path quality
Bazel analysis benchmark
|
Reduce usage of rules_python and heavy pip parsing in root MODULE.
Changes are visible to end-users: no
Test plan