Preserve embedded resource constraint errors - #2789
Open
BrendanWillis wants to merge 1 commit into
Open
Conversation
zachdaniel
reviewed
Jul 22, 2026
| defp normalize_error_input(other, _opts), do: other | ||
|
|
||
| defp supported_error_keyword?(keyword) do | ||
| Enum.any?([:field, :fields, :message, :path, :index, :value, :private_vars], fn key -> |
Contributor
There was a problem hiding this comment.
I think this is a bit of a code smell, us having to detect a special kind of keyword list. In general I think this should be detected in the code for embedded types and handled at the source of these errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.
Preserves detailed validation errors when invalid values are found in embedded resources.
Previously, an embedded value could fail during dumping and lose useful constraint information. This caused the final error to have less detail than expected.
Changes