Skip to content

[bugfix]: drop redundant h3_sequential_load from Spark FastH3 configs - #36

Closed
aryan5v wants to merge 21 commits into
mainfrom
aryan5v/fix-spark-h3-load-config-659e
Closed

[bugfix]: drop redundant h3_sequential_load from Spark FastH3 configs#36
aryan5v wants to merge 21 commits into
mainfrom
aryan5v/fix-spark-h3-load-config-659e

Conversation

@aryan5v

@aryan5v aryan5v commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Problem

The three Spark FastH3 YAML presets shipped with both lazy_module_load: true and h3_sequential_load: true. On GB10/unified memory, lazy_module_load owns component deferral and explicitly suppresses sequential load (see _defer_denoise_modules in minimax_h3_pipeline.py, fixed in the hao-ai-lab#1803 review). The h3_sequential_load flag in those configs was therefore dead and misleading.

Solution

  • Remove h3_sequential_load: true from:
    • examples/inference/basic/basic_fasth3_spark.yaml
    • examples/inference/basic/basic_fasth3_spark_pair.yaml
    • examples/serving/openai_fasth3_spark.yaml
  • Document in each file that lazy_module_load is the Spark deferral path; h3_sequential_load remains the H3-only fallback when lazy is off (--no-lazy-module-load).
  • Add a regression test in tests/local_tests/test_cookbook_serving.py.

Context

Sequential load is not dead code — it is still used on discrete GPUs without lazy load, or when --no-lazy-module-load is passed on Spark.

Testing

  • Added test_spark_configs_use_lazy_load_not_sequential (requires dev env with torch/pytest to run locally).
Open in Web Open in Cursor 

SolitaryThinker and others added 21 commits August 28, 2026 22:29
Co-authored-by: Aryan Kumar <aryan5v@users.noreply.github.com>
Co-authored-by: Aryan Kumar <aryan5v@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…nse GEMM (hao-ai-lab#1788)

Co-authored-by: Aryan Kumar <aryan5v@users.noreply.github.com>
Co-authored-by: Aryan Kumar <aryan5v@users.noreply.github.com>
Co-authored-by: Aryan Kumar <aryan5v@users.noreply.github.com>
…ab#1793)

Co-authored-by: Aryan Kumar <aryan5v@users.noreply.github.com>
Co-authored-by: Aryan Kumar <aryan5v@users.noreply.github.com>
Co-authored-by: Aryan Kumar <aryan5v@users.noreply.github.com>
Co-authored-by: Shahrad Zomorrodi <264690209+shahradzomorrodi@users.noreply.github.com>
)

Co-authored-by: Aryan Kumar <aryan5v@users.noreply.github.com>
…ao-ai-lab#1803)

Co-authored-by: Kyle <shh075@ucsd.edu>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Satyam Srivastava <srivastavasatyam53@gmail.com>
Co-authored-by: Aryan Kumar <aryan5v@users.noreply.github.com>
hao-ai-lab#1805)

Co-authored-by: Vaish, Ishan <isvaish@UCSD.EDU>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Fold the two-Spark recipe into FastH3 Preview so users pick NVIDIA DGX Spark,
then 1 Spark or 2 Sparks, instead of a separate catalog card.
lazy_module_load owns component deferral on GB10; h3_sequential_load is
suppressed when lazy is on (hao-ai-lab#1803 review). Remove the dead flag from the
three Spark YAML presets and add a regression test.

Co-authored-by: Aryan Kumar <aryan5v@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aryan5v aryan5v closed this Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants