Skip to content

ADE Stats accuracy overhaul + activity module redesign (ADE-113, ADE-114) #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arul28 merged 16 commits into from
Jul 11, 2026
Merged

ADE Stats accuracy overhaul + activity module redesign (ADE-113, ADE-114) #783

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ff2f3b0
Stats accuracy fixes + activity module redesign (desktop)
arul28 Jul 10, 2026
4ed22d1
iOS: port redesigned activity module to Work new-chat screen
arul28 Jul 10, 2026
b971221
Usage e2e fixture + codeburn oracle harness; ledger accuracy fixes
arul28 Jul 10, 2026
740ecd4
Quality pass: review-verified fixes for stats pipeline and activity UI
arul28 Jul 10, 2026
8e042a8
Parity pass: scope forwarding on remote usage command + docs refresh
arul28 Jul 10, 2026
4726c49
Activity heatmap fills chart area; per-tab empty hints (desktop + iOS)
arul28 Jul 10, 2026
3c6e7c6
Forward custom since/until ranges through the sync usage command
arul28 Jul 10, 2026
e971675
Fix tz-dependent e2e assertions; exact-range ADE/external split
arul28 Jul 10, 2026
db50b32
Review round: day-granular custom ranges, IPC validation, heatmap/too…
arul28 Jul 10, 2026
6f549d3
Merge main (#782 ADE-117 quota reliability) into stats overhaul lane
arul28 Jul 10, 2026
4dd7b14
Exact active-day and streak counts under the daily-row cap
arul28 Jul 10, 2026
6ac5adc
Unify day-activity scoring across every dimension (desktop + iOS)
arul28 Jul 10, 2026
ae79cb4
Count file-only session deltas as active days
arul28 Jul 10, 2026
fd8c81e
iOS: legacy totalTokens-only days count as active
arul28 Jul 10, 2026
dafaabb
iOS: render legacy total-only token days in bucket bars
arul28 Jul 10, 2026
adffa32
iOS: tap details include unsplit legacy tokens
arul28 Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions apps/ade-cli/src/services/sync/syncRemoteCommandService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,29 @@ describe("createSyncRemoteCommandService", () => {
await expect(service.execute(makePayload("usage.getAdeStats", { preset: "decade" }))).rejects.toThrow(
"usage.getAdeStats preset must be today, 7d, 30d, year, or all.",
);

getAdeUsageStats.mockClear();
await service.execute(makePayload("usage.getAdeStats", { preset: "7d", scope: "project" }));
expect(getAdeUsageStats).toHaveBeenCalledWith({ preset: "7d", scope: "project" });
await expect(service.execute(makePayload("usage.getAdeStats", { scope: "galaxy" }))).rejects.toThrow(
"usage.getAdeStats scope must be machine or project.",
);

getAdeUsageStats.mockClear();
await service.execute(makePayload("usage.getAdeStats", {
since: "2026-07-01T00:00:00.000Z",
until: "2026-07-08T00:00:00.000Z",
}));
expect(getAdeUsageStats).toHaveBeenCalledWith({
since: "2026-07-01T00:00:00.000Z",
until: "2026-07-08T00:00:00.000Z",
});
await expect(service.execute(makePayload("usage.getAdeStats", { since: "not-a-date" }))).rejects.toThrow(
"usage.getAdeStats since must be an ISO timestamp.",
);
await expect(service.execute(makePayload("usage.getAdeStats", { until: "not-a-date" }))).rejects.toThrow(
"usage.getAdeStats until must be an ISO timestamp.",
);
});

it("advertises and executes machine personal chats as runtime commands", async () => {
Expand Down
17 changes: 16 additions & 1 deletion apps/ade-cli/src/services/sync/syncRemoteCommandService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ import type {
UpdatePrTitleArgs,
WriteTextAtomicArgs,
} from "../../../../desktop/src/shared/types";
import { isAdeUsageRangePreset } from "../../../../desktop/src/shared/types";
import { isAdeUsageRangePreset, isAdeUsageScope } from "../../../../desktop/src/shared/types";
import type { OrchestrationRunCreateRequest } from "../../../../desktop/src/shared/types/orchestration";
import { PERSONAL_CHAT_ACTIONS, isPersonalChatActionQueueable } from "../../../../desktop/src/shared/types/personalChats";
import {
Expand Down Expand Up @@ -4527,8 +4527,23 @@ export function createSyncRemoteCommandService(args: SyncRemoteCommandServiceArg
if (preset && !isAdeUsageRangePreset(preset)) {
throw new Error("usage.getAdeStats preset must be today, 7d, 30d, year, or all.");
}
const scope = asTrimmedString(payload.scope);
if (scope && !isAdeUsageScope(scope)) {
throw new Error("usage.getAdeStats scope must be machine or project.");
}
const since = asTrimmedString(payload.since);
if (since && Number.isNaN(Date.parse(since))) {
throw new Error("usage.getAdeStats since must be an ISO timestamp.");
}
const until = asTrimmedString(payload.until);
if (until && Number.isNaN(Date.parse(until))) {
throw new Error("usage.getAdeStats until must be an ISO timestamp.");
}
return await args.usageTrackingService.getAdeUsageStats({
...(isAdeUsageRangePreset(preset) ? { preset } : {}),
...(isAdeUsageScope(scope) ? { scope } : {}),
...(since ? { since } : {}),
...(until ? { until } : {}),
});
Comment thread
greptile-apps[bot] marked this conversation as resolved.
});

Expand Down
Loading