-
Notifications
You must be signed in to change notification settings - Fork 12
iOS: unify host connection status in navigation bar #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+338
−778
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7211bed
ios: unify host connection status in nav bar
cursoragent 446540d
ios: harden connection dot for a11y, syncing, and deep screens
cursoragent 45f7851
fix: address PR review items and flaky CI (desktop shard 7)
cursoragent 54d05d2
fix: address Capy/Greptile review on hydration errors and planner res…
cursoragent 5af6c62
Merge remote-tracking branch 'origin/main' into cursor/ios-unify-conn…
arul28 91fd90c
fix: address remaining PR review comments
arul28 a1fe2fc
chore: finalize — simplify, drop unused props, update docs
arul28 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[🟡 Medium] [🔵 Bug]
This helper treats
report_result.plan.markdownas sufficient proof that recovery succeeded:updateWorkerStateFromEventCtx()invokes it immediately afterextractAndRegisterArtifacts(), but that function wraps plan-file writes and artifact registration in a top-levelartifact_extraction_failedcatch. When a recovery attempt returns markdown butfs.writeFileSync/registerArtifactthrows, ADE skips persisting.ade/plans/mission-plan.mdand still auto-resolves the oldplanner_plan_missingintervention here, allowing the mission to leaveintervention_requiredwithout the canonical plan artifact. Gate this resolution on confirmedplanartifact persistence/registration instead of the reported markdown alone.