t3code-inspired features: model slug, PR ahead hints, chat UX, settings

apps/desktop/src/main/services/prs/prService.mobileSnapshot.test.ts

@@ -306,6 +306,7 @@ describe("prService.getMobileSnapshot", () => {
     const eligibleEntry = snapshot.createCapabilities.lanes.find((lane) => lane.laneId === "lane-feat")!;
     expect(eligibleEntry.canCreate).toBe(true);
     expect(eligibleEntry.blockedReason).toBeNull();
+    expect(eligibleEntry.commitsAheadOfBase).toBe(0);
   });
 
   it("includes queue and rebase workflow cards and skips completed queues", async () => {

apps/desktop/src/main/services/prs/prService.ts

@@ -5510,6 +5510,7 @@ export function createPrService({
         primaryBranchRef: primaryLane?.branchRef ?? null,
       });
       const dirty = lane.status?.dirty === true;
+      const commitsAheadOfBase = Math.max(0, Number(lane.status?.ahead ?? 0) || 0);
       const hasExistingPr = existingPr !== null && (existingPr.state === "open" || existingPr.state === "draft");
       const canCreate = !hasExistingPr;
       const blockedReason = hasExistingPr
@@ -5524,6 +5525,7 @@ export function createPrService({
         defaultBaseBranch,
         defaultTitle: lane.name,
         dirty,
+        commitsAheadOfBase,
         hasExistingPr,
         canCreate,
         blockedReason,

apps/desktop/src/renderer/components/app/AppShell.test.tsx

@@ -332,6 +332,44 @@ describe("AppShell", () => {
       expect(
         screen.getByText(/No AI provider is configured yet/i),
       ).toBeTruthy();
+
+      fireEvent.click(screen.getByTestId("dismiss-missing-ai-banner"));
+
+      expect(
+        screen.queryByText(/No AI provider is configured yet/i),
+      ).toBeNull();
+    } finally {
+      vi.useRealTimers();
+    }
+  });
+
+  it("dismisses the GitHub not connected banner for the current session", async () => {
+    vi.useFakeTimers();
+    try {
+      globalThis.window.ade.github.getStatus = vi.fn(async () => ({ tokenStored: false })) as any;
+
+      render(
+        <MemoryRouter initialEntries={["/work"]}>
+          <AppShell>
+            <div>child</div>
+          </AppShell>
+        </MemoryRouter>,
+      );
+
+      await act(async () => {
+        vi.advanceTimersByTime(1_000);
+        await Promise.resolve();
+      });
+
+      expect(
+        screen.getByText(/GitHub is not connected for this ADE app yet/i),
+      ).toBeTruthy();
+
+      fireEvent.click(screen.getByTestId("dismiss-github-banner"));
+
+      expect(
+        screen.queryByText(/GitHub is not connected for this ADE app yet/i),
+      ).toBeNull();
     } finally {
       vi.useRealTimers();
     }

apps/desktop/src/renderer/components/app/AppShell.tsx

@@ -182,6 +182,12 @@ export function AppShell({ children }: { children: React.ReactNode }) {
   );
   const [dismissedContextBannerRoots, setDismissedContextBannerRoots] =
     useState<Record<string, true>>({});
+  /** Session dismiss for the “no AI provider” banner (per project root). */
+  const [dismissedMissingAiBannerRoots, setDismissedMissingAiBannerRoots] =
+    useState<Record<string, true>>({});
+  /** Session dismiss for the “GitHub not connected” banner (per project root). */
+  const [dismissedGithubBannerRoots, setDismissedGithubBannerRoots] =
+    useState<Record<string, true>>({});
   const [projectMissing, setProjectMissing] = useState(false);
   const [feedbackGenerating, setFeedbackGenerating] = useState(false);
   const previousProjectRootRef = useRef<string | null | undefined>(undefined);
@@ -480,6 +486,11 @@ export function AppShell({ children }: { children: React.ReactNode }) {
     setProjectMissing(false);
   }, [project?.rootPath]);
 
+  useEffect(() => {
+    setDismissedMissingAiBannerRoots({});
+    setDismissedGithubBannerRoots({});
+  }, [project?.rootPath]);
+
   useEffect(() => {
     const previousProjectRoot = previousProjectRootRef.current;
     const nextProjectRoot = project?.rootPath ?? null;
@@ -603,6 +614,12 @@ export function AppShell({ children }: { children: React.ReactNode }) {
     [missingContextDocs],
   );
   const currentProjectRoot = project?.rootPath ?? null;
+  const missingAiBannerDismissed = Boolean(
+    currentProjectRoot && dismissedMissingAiBannerRoots[currentProjectRoot],
+  );
+  const githubBannerDismissed = Boolean(
+    currentProjectRoot && dismissedGithubBannerRoots[currentProjectRoot],
+  );
   const contextBannerDismissed = Boolean(
     currentProjectRoot && dismissedContextBannerRoots[currentProjectRoot],
   );
@@ -791,12 +808,30 @@ export function AppShell({ children }: { children: React.ReactNode }) {
       !showWelcome &&
       aiStatusLoaded &&
       aiStatus !== null &&
-      !hasAnyAiProvider ? (
+      !hasAnyAiProvider &&
+      !missingAiBannerDismissed ? (
         <div className="shrink-0 mx-2 mt-1 rounded bg-amber-500/6 px-3 py-1.5 text-[11px] font-mono text-amber-800">
-          No AI provider is configured yet.{" "}
-          <Link to="/settings?tab=ai" className="underline">
-            Set up AI
-          </Link>
+          <span>
+            No AI provider is configured yet.{" "}
+            <Link to="/settings?tab=ai" className="underline">
+              Set up AI
+            </Link>
+          </span>
+          <button
+            type="button"
+            data-testid="dismiss-missing-ai-banner"
+            className="ml-2 text-amber-900/70 hover:text-amber-900"
+            onClick={() => {
+              if (!currentProjectRoot) return;
+              setDismissedMissingAiBannerRoots((prev) => ({
+                ...prev,
+                [currentProjectRoot]: true,
+              }));
+            }}
+            title="Dismiss for this session"
+          >
+            ×
+          </button>
         </div>
       ) : null}
 
@@ -805,12 +840,30 @@ export function AppShell({ children }: { children: React.ReactNode }) {
       !showWelcome &&
       !isOnboardingRoute &&
       githubStatus !== null &&
-      !githubStatus.tokenStored ? (
+      !githubStatus.tokenStored &&
+      !githubBannerDismissed ? (
         <div className="shrink-0 mx-3 mt-1.5 rounded bg-amber-500/6 px-3 py-1.5 text-[11px] font-mono text-amber-800">
-          GitHub is not connected for this ADE app yet.{" "}
-          <Link to="/settings?tab=integrations" className="underline">
-            Connect GitHub
-          </Link>
+          <span>
+            GitHub is not connected for this ADE app yet.{" "}
+            <Link to="/settings?tab=integrations" className="underline">
+              Connect GitHub
+            </Link>
+          </span>
+          <button
+            type="button"
+            data-testid="dismiss-github-banner"
+            className="ml-2 text-amber-900/70 hover:text-amber-900"
+            onClick={() => {
+              if (!currentProjectRoot) return;
+              setDismissedGithubBannerRoots((prev) => ({
+                ...prev,
+                [currentProjectRoot]: true,
+              }));
+            }}
+            title="Dismiss for this session"
+          >
+            ×
+          </button>
         </div>
       ) : null}
 

apps/desktop/src/renderer/components/chat/AgentChatPane.tsx

@@ -76,6 +76,7 @@ import { ClaudeCacheTtlBadge } from "../shared/ClaudeCacheTtlBadge";
 import { shouldShowClaudeCacheTtl } from "../../lib/claudeCacheTtl";
 import { getAgentChatModelsCached, getAiStatusCached } from "../../lib/aiDiscoveryCache";
 import { invalidateSessionListCache } from "../../lib/sessionListCache";
+import { playAgentTurnCompletionSound } from "../../lib/agentTurnCompletionSound";
 
 const LAST_MODEL_ID_KEY = "ade.chat.lastModelId";
 const LAST_REASONING_KEY_PREFIX = "ade.chat.lastReasoningEffort";
@@ -710,6 +711,7 @@ export function AgentChatPane({
   onLaneChange?: (laneId: string) => void;
 }) {
   const projectRoot = useAppStore((s) => s.project?.rootPath ?? null);
+  const agentTurnCompletionSound = useAppStore((s) => s.agentTurnCompletionSound);
   const navigate = useNavigate();
   const openAiProvidersSettings = useCallback(() => {
     navigate("/settings?tab=ai#ai-providers");
@@ -777,6 +779,8 @@ export function AgentChatPane({
   const shellRef = useRef<HTMLElement | null>(null);
   const composerMaxHeightPx = layoutVariant === "grid-tile" ? 144 : null;
   const sessionsRef = useRef<AgentChatSessionSummary[]>(sessions);
+  const completionSoundPrevTurnActiveRef = useRef(false);
+  const completionSoundArmedRef = useRef(true);
 
   const appliedInitialSessionIdRef = useRef<string | null>(initialSessionId ?? null);
   const loadedHistoryRef = useRef<Set<string>>(new Set());
@@ -824,6 +828,40 @@ export function AgentChatPane({
   const pendingInput = selectedSessionId ? (pendingInputsBySession[selectedSessionId]?.[0] ?? null) : null;
   const selectedSessionAwaitingInput = Boolean(pendingInput) || selectedSession?.awaitingInput === true;
   const turnActive = selectedSessionId ? (turnActiveBySession[selectedSessionId] ?? false) : false;
+
+  useEffect(() => {
+    completionSoundPrevTurnActiveRef.current = false;
+    completionSoundArmedRef.current = true;
+  }, [selectedSessionId]);
+
+  useEffect(() => {
+    if (agentTurnCompletionSound === "off") {
+      completionSoundPrevTurnActiveRef.current = turnActive;
+      return;
+    }
+    if (turnActive) {
+      completionSoundArmedRef.current = true;
+    }
+    const sessionEnded = selectedSession?.status === "ended";
+    const settled =
+      Boolean(selectedSessionId)
+      && !selectedSessionAwaitingInput
+      && !sessionEnded;
+    const prevTurn = completionSoundPrevTurnActiveRef.current;
+    const becameIdle = settled && prevTurn && !turnActive;
+    completionSoundPrevTurnActiveRef.current = turnActive;
+    if (becameIdle && completionSoundArmedRef.current) {
+      completionSoundArmedRef.current = false;
+      playAgentTurnCompletionSound(agentTurnCompletionSound);
+    }
+  }, [
+    agentTurnCompletionSound,
+    selectedSessionId,
+    selectedSession?.status,
+    selectedSessionAwaitingInput,
+    turnActive,
+  ]);
+
   const activeProviderConnection = selectedSession?.provider === "claude"
     ? (providerConnections?.claude ?? null)
     : selectedSession?.provider === "codex"

apps/desktop/src/renderer/components/chat/CodeHighlighter.tsx

@@ -1,5 +1,6 @@
 import React, { Suspense, useCallback, useEffect, useState, useRef } from "react";
 import { CopySimple, Checks } from "@phosphor-icons/react";
+import { useAppStore, type CodeBlockCopyButtonPosition } from "../../state/appStore";
 
 /* ── LRU cache for highlighted HTML ── */
 
@@ -113,25 +114,47 @@ function DiffCodeBlock({ code }: { code: string }) {
 
 /* ── Copy button ── */
 
-function CodeCopyButton({ code }: { code: string }) {
+function copyTextToClipboard(text: string): Promise<boolean> {
+  if (typeof navigator !== "undefined" && navigator.clipboard?.writeText) {
+    return navigator.clipboard.writeText(text).then(() => true).catch(() => false);
+  }
+  try {
+    const ta = document.createElement("textarea");
+    ta.value = text;
+    ta.setAttribute("readonly", "");
+    ta.style.position = "fixed";
+    ta.style.left = "-9999px";
+    document.body.appendChild(ta);
+    ta.select();
+    const ok = document.execCommand("copy");
+    document.body.removeChild(ta);
+    return Promise.resolve(ok);
+  } catch {
+    return Promise.resolve(false);
+  }
+}
+
+function CodeCopyButton({ code, position }: { code: string; position: CodeBlockCopyButtonPosition }) {
   const [copied, setCopied] = useState(false);
 
   const handleCopy = useCallback(() => {
-    if (typeof navigator === "undefined" || !navigator.clipboard?.writeText) return;
-    void navigator.clipboard.writeText(code)
-      .then(() => {
+    void copyTextToClipboard(code)
+      .then((ok) => {
+        if (!ok) {
+          setCopied(false);
+          return;
+        }
         setCopied(true);
         window.setTimeout(() => setCopied(false), 1_500);
-      })
-      .catch(() => {
-        setCopied(false);
       });
   }, [code]);
 
+  const posClass = position === "bottom" ? "bottom-2 top-auto" : "top-2";
+
   return (
     <button
       type="button"
-      className="absolute right-2 top-2 z-10 inline-flex items-center gap-1 rounded-md border border-white/[0.08] bg-white/[0.03] px-1.5 py-0.5 font-sans text-[9px] text-fg/45 opacity-0 backdrop-blur-sm transition-all group-hover:opacity-100 hover:border-white/[0.14] hover:bg-white/[0.05] hover:text-fg/72"
+      className={`absolute right-2 z-10 inline-flex items-center gap-1 rounded-md border border-white/[0.08] bg-white/[0.03] px-1.5 py-0.5 font-sans text-[9px] text-fg/45 opacity-0 backdrop-blur-sm transition-all group-hover:opacity-100 [@media(hover:none)]:opacity-100 hover:border-white/[0.14] hover:bg-white/[0.05] hover:text-fg/72 ${posClass}`}
       onClick={handleCopy}
       title={copied ? "Copied" : "Copy code"}
       aria-label={copied ? "Copied" : "Copy code"}
@@ -223,12 +246,13 @@ export const HighlightedCode = React.memo(function HighlightedCode({
   code: string;
   language: string;
 }) {
+  const copyButtonPosition = useAppStore((s) => s.codeBlockCopyButtonPosition);
   const trimmedCode = code.replace(/\n$/, "");
   const isDiff = language === "diff";
 
   return (
     <div className="group relative my-3 overflow-hidden rounded-[10px] border border-[color:var(--chat-code-border)] bg-[var(--chat-code-bg)]">
-      <CodeCopyButton code={trimmedCode} />
+      <CodeCopyButton code={trimmedCode} position={copyButtonPosition} />
       <div className="overflow-x-auto whitespace-pre-wrap break-words px-4 py-3">
         {isDiff ? (
           <DiffCodeBlock code={trimmedCode} />