Skip to content

Add Reviewer Guidance: Comment/Approve/ Request Changes. #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simpal01 wants to merge 2 commits into
base: arm-software
Choose a base branch
from
Open

Add Reviewer Guidance: Comment/Approve/ Request Changes. #639

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4a2dbc
Add Reviewer Guidance: Comment/Approve/ Request Changes.
simpal01 Dec 8, 2025
45e25bc
fixup! Add Reviewer Guidance: Comment/Approve/ Request Changes.
simpal01 Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,21 @@ If the issue is in Arm Toolchain itself, or if you are not sure, please create a
Please attach any support files to the issue itself,
see [Attaching files](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/attaching-files).

### Reviewing Patches

@kiranchandramohan kiranchandramohan Dec 14, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a context for these changes? Otherwise it seems like stating the obvious. Is this for engineers who have not worked with Github before?


All contributions to Arm Toolchain are reviewed through GitHub Pull Requests.
If you are asked to review a patch, or would like to understand the review process, please follow the guidance below.

How to Review a Pull Request

When reviewing a PR, you can provide feedback, approve the changes, or request updates using GitHub’s standard review options:

@kiranchandramohan kiranchandramohan Dec 14, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would everyone have the permissions to approve or request changes?

@kiranchandramohan kiranchandramohan Dec 14, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When reviewing a PR, you can provide feedback, approve the changes, or request updates using GitHub’s standard review options:
When reviewing a PR, you can provide feedback, approve the PR, or request changes using GitHub’s standard review options:

@saturn691 saturn691 Dec 15, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this suggestion

* Comment – leave feedback without blocking the merge.
* Approve – Approve merging the changes proposed in the PR.
* Request changes – block the merge until required updates are made.

For full guidance on how to review patches and use these options, please refer to GitHub’s documentation:
see [Reviewing Proposed Changes in a PR](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request)

### Submit a fix

For a small change, please create a Pull Request as described in
Expand Down