Skip to content

fix: four components hide ArenaComponent.Update(), dropping repeat attribute messages #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
claude wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: four components hide ArenaComponent.Update(), dropping repeat attribute messages #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Runtime/Components/ArenaClickListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace ArenaUnity.Components
public class ArenaClickListener : ArenaComponent
{
// ARENA click-listener component unity conversion status:
// DONE: enabled
// TODO: enabled
// TODO: bubble

private Camera _camera;
Expand All @@ -26,8 +26,10 @@ public class ArenaClickListener : ArenaComponent

public ArenaClickListenerJson json = new ArenaClickListenerJson();

private new void Update()
protected override void Update()
{
base.Update();

// discover which camera to use for collisions
_camera = Camera.main;
if (_camera != null && _arenaCam == null)
Expand Down Expand Up @@ -145,7 +147,9 @@ internal void PublishMouseEvent(string eventType)

protected override void ApplyRender()
{
throw new System.NotImplementedException();
// no Unity conversion yet, warn only when the scene asks for non-default behavior
if (!json.Enabled || !json.Bubble)
Debug.LogWarning($"click-listener 'enabled' and 'bubble' are not implemented in Unity, ignored for '{name}'.");
}

public override void UpdateObject()
Expand Down
4 changes: 3 additions & 1 deletion Runtime/Components/ArenaGltfMorph.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@ protected override void ApplyRender()
morphApplied = false;
}

private new void Update()
protected override void Update()
{
base.Update();

if (!morphApplied)
{
var gltfModel = GetComponent<ArenaWireGltfModel>();
Expand Down
4 changes: 3 additions & 1 deletion Runtime/Components/ArenaMaterialExtras.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,10 @@ protected override void ApplyRender()
materialApplied = false;
}

private new void Update()
protected override void Update()
{
base.Update();

if (!materialApplied)
{
var gltfModel = GetComponent<ArenaWireGltfModel>();
Expand Down
4 changes: 3 additions & 1 deletion Runtime/Components/ArenaModelUpdate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@ protected override void ApplyRender()
modelApplied = false;
}

private new void Update()
protected override void Update()
{
base.Update();

if (!modelApplied)
{
var gltfModel = GetComponent<ArenaWireGltfModel>();
Expand Down