Skip to content

fix: elide unset url and dep in hand DTOs #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
claude wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: elide unset url and dep in hand DTOs #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions Runtime/Schemas/Object/ArenaHandLeftJson.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,23 @@ public class ArenaHandLeftJson
{
public string object_type = "handLeft";

public string url { get; set; }
public string dep { get; set; }
private static string defUrl = null;
[JsonProperty(PropertyName = "url")]
[Tooltip("Path to the hand controller 3D model.")]
public string url = defUrl;
public bool ShouldSerializeurl()
{
return (url != defUrl);
}

private static string defDep = null;
[JsonProperty(PropertyName = "dep")]
[Tooltip("User id this hand belongs to.")]
public string dep = defDep;
public bool ShouldSerializedep()
{
return (dep != defDep);
}

[JsonProperty(PropertyName = "parent")]
[Tooltip("Parent's object_id. Child objects inherit attributes of their parent, for example scale and translation.")]
Expand Down
19 changes: 17 additions & 2 deletions Runtime/Schemas/Object/ArenaHandRightJson.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,23 @@ public class ArenaHandRightJson
{
public string object_type = "handRight";

public string url { get; set; }
public string dep { get; set; }
private static string defUrl = null;
[JsonProperty(PropertyName = "url")]
[Tooltip("Path to the hand controller 3D model.")]
public string url = defUrl;
public bool ShouldSerializeurl()
{
return (url != defUrl);
}

private static string defDep = null;
[JsonProperty(PropertyName = "dep")]
[Tooltip("User id this hand belongs to.")]
public string dep = defDep;
public bool ShouldSerializedep()
{
return (dep != defDep);
}

[JsonProperty(PropertyName = "parent")]
[Tooltip("Parent's object_id. Child objects inherit attributes of their parent, for example scale and translation.")]
Expand Down