overlap safety call in MSC with relocation - #688
Open
SeverinDiederichs wants to merge 1 commit into
Open
Conversation
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, in the split kernels, the ElectronMSC did the
PerformContinuouscall to G4HepEm and then the displacement. In case there is no safety left, the displacement involved the expensiveComputeSafetycall. As this does not happen if the particle is on boundary (since it skips displacement on boundary), the displacement gives some divergence.This can be avoided:
Instead, the Displacement and ComputeSafety calls can be moved to the
SetupElectronInteractionkernel. Then, at the end of ElectronMSC, the particles are either enqueued directly to the Relocation kernel or to theSetupElectronInteractions. Then, the geometry calls in Relocation can overlap with the geometry call inComputeSafetyin theSetupElectronInteractions.This PR gives identical results to the current master branch, performance still need to be tested in detail.