Reject rewrite HTTPS downgrades; close intermediate redirect responses#1749
Open
KushalP wants to merge 1 commit into
Open
Reject rewrite HTTPS downgrades; close intermediate redirect responses#1749KushalP wants to merge 1 commit into
KushalP wants to merge 1 commit into
Conversation
Both issues are in `RequestRewritingClient.doSend`. It follows redirects by hand now that the JDK client uses `Redirect.NEVER`. ## Downgrade guard The guard read the raw `Location` scheme before applying rewrites. So a rewrite from `https` to `http` slipped a cleartext request past it. Now the code rewrites first, then checks the scheme. ## Connection leak The loop dropped each intermediate `3xx` response without closing it. That leaked one `BodyHandlers.ofInputStream()` connection per hop. Now the code closes the body before following the redirect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both issues are in
RequestRewritingClient.doSend. It follows redirects by hand now that the JDK client usesRedirect.NEVER.Downgrade guard
The guard read the raw
Locationscheme before applying rewrites. So a rewrite fromhttpstohttpslipped a cleartext request past it. Now the code rewrites first, then checks the scheme.Connection leak
The loop dropped each intermediate
3xxresponse without closing it. That leaked oneBodyHandlers.ofInputStream()connection per hop. Now the code closes the body before following the redirect.