Add this as a self type#1708
Open
HT154 wants to merge 1 commit into
Open
Conversation
HT154
force-pushed
the
this-type
branch
3 times, most recently
from
6fb74b2 to
fa93f3d
Compare
HT154
force-pushed
the
this-type
branch
3 times, most recently
from
a1d16f8 to
55f923c
Compare
HT154
force-pushed
the
this-type
branch
19 times, most recently
from
71958eb to
a8c3282
Compare
HT154
commented
Jul 2, 2026
| sourceSection, clazz, PType.MODULE, MirrorFactories.moduleTypeFactory); | ||
| } | ||
|
|
||
| public static FinalSelfTypeNode thiz(SourceSection sourceSection, VmClass clazz) { |
Contributor
Author
There was a problem hiding this comment.
Any recs for a better name here? 😅
HT154
commented
Jul 2, 2026
Comment on lines
+190
to
+194
| /** | ||
| * If {@code frame} is provided then self types should be resolved to real types, otherwise return | ||
| * the self PType | ||
| */ | ||
| protected PType doExport(@Nullable VirtualFrame frame) { |
Contributor
Author
There was a problem hiding this comment.
ReferenceTypeNode needs to export the real class here, so when a frame is passed NonFinalSelfTypeNode uses it to get the target's class instead of exporting PType.MODULE/PType.THIS.
HT154
force-pushed
the
this-type
branch
2 times, most recently
from
41b3a9f to
9d20551
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
this, a fully featured self type for use in modules or classes.thisin typealias bodies.moduletype in class and typealias bodies with a warning, to be an error in a future release.moduletypes as typelias type args are evaluated in the context of the alias's module, not wheremoduleis used #1712).thisor a self-import and use of the current module.thisin the standard library:pkl.base#Any.getClass()now returnsClass<this>.pkl.ref#Domain.renderReference()now accepts aReference<this, Any>.ReferenceTypeNode,moduletypes, and type aliases that causedmoduletypes in the referent position to always be resolved to the module where theReferencetype annotation is instead of wheremoduleis used.Resolves #1612
Resolves #1712