Skip to content

K2GO-566 fix(maps): carry a fix for the second FQR rectangle - #763

Merged
luisguzman-adfa merged 1 commit into
mainfrom
fix/K2GO-566-maps-fqr-second-rectangle
Nov 13, 2026
Merged

luisguzman-adfa merged 1 commit into
mainfrom
fix/K2GO-566-maps-fqr-second-rectangle

Conversation

@luisguzman-adfa

Copy link
Copy Markdown
Collaborator

What changes

  • Add carry patch 0006-maps-fqr-second-rectangle.patch for roles/maps/templates/index.html.j2: removeOtherRectangles uses thisControl instead of this.

Why

  • this is undefined in that inner function. When you draw a second region rectangle, the page throws a TypeError, the new rectangle is not drawn, and the tool stops until Cancel.

Verifications

  • Fix applied live on a OnePlus 7T: the second rectangle replaces the first, 0 errors. A burst of 8 taps plus a drag: 0 errors.
  • Patch script: applies on the current upstream master. It skips the patch on a second run and when the upstream file already has the fix.

Notes

  • Only new rootfs bakes get the fix. Installed devices keep the bug until a reinstall or a maps role re-run.
  • Remove this patch when the pinned iiab/iiab commit has the fix. The patch script already skips it then.

removeOtherRectangles used `this` (undefined) instead of thisControl, so a
second region rectangle threw a TypeError and froze the tool.
@luisguzman-adfa
luisguzman-adfa merged commit ed7e69b into main Nov 13, 2026
3 checks passed
@luisguzman-adfa
luisguzman-adfa deleted the fix/K2GO-566-maps-fqr-second-rectangle branch November 13, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant