Repository navigation
K2GO-566 fix(maps): carry a fix for the second FQR rectangle - #763
Merged
Merged
Conversation
removeOtherRectangles used `this` (undefined) instead of thisControl, so a second region rectangle threw a TypeError and froze the tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
0006-maps-fqr-second-rectangle.patchforroles/maps/templates/index.html.j2:removeOtherRectanglesusesthisControlinstead ofthis.Why
thisis undefined in that inner function. When you draw a second region rectangle, the page throws a TypeError, the new rectangle is not drawn, and the tool stops until Cancel.Verifications
Notes