Repository navigation
K2GO-317 fix(maps): FQR download progress, ETA, and resume resilience - #746
Merged
Merged
Conversation
…op ring Ring and ETA now run off cumulative bytes vs the consent estimate (device sends est) and an EMA-smoothed speed, not go-pmtiles per-layer eta_s or the 1/3-per-layer buckets that made the time jump and the ring stick. On resume the ring holds its peak and blinks instead of falling to 0; ETA stacks "6 s" over "restantes". dash-node 1.4.13.
…R downloads Pause waits for go-pmtiles to flush its journal (unbounded fsync); SIGKILL is a last-resort cap. Stall watchdog fires only on a true wedge (no bytes and no retries for 30 s, a retry counts as activity). New idle watchdog pauses on 30 s with no progress line (frozen process). dash-node 1.5.0.
Interim bake carry (0004): pin the maps-role pmtiles binary to r2 (armhf, arm64, amd64). r2 skips an already-complete layer on resume, so a resume no longer re-downloads a finished layer. Drop when the upstream maps-role update pins r2 (as 0003 was dropped for iiab#4565).
… network error tile-extract.py's own mirror/catalog request (its requests.head between layers) can fail with a transient network error, which carries no go-pmtiles exit_code 2. The catch treated it as a hard error and purged every completed layer, so a retry re-downloaded them. Detect the stderr signature and treat it as resumable (keep partials, pause), so a resume skips the completed layers via r2. dash-node 1.5.0.
Print the commit (short hash + subject) between the git reset and the staging build, so the operator can confirm the rebuild is building the intended commit.
onDone relied on updateOverlay(100) to stop the resume blink (100 >= peak is non-regressing). Make it explicit so every exit path (pause, fail, hide, done) stops the blink, robust against future updateOverlay changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Why
Verifications
tsc --noEmitclean; chained 2-pass review on the runner changes: no findings.patch -p1): forward, reverse, idempotent, byte-exact result.Notes
uilabel (progress ring and ETA behavior change).