Repository navigation
K2GO-503 feat(updaters): overall progress and total ETA for add-ons/assets - #677
Merged
Merged
Conversation
…ssets Aggregate aria2 progress through its RPC into one monotonic bar with aggregate speed and total ETA; unify the duplicated add-ons/assets refresh views into one ContentUpdaterView behind a ContentUpdater adapter (fixes the dancing bar, the duplicate label, and the up-to-date message).
…/K2GO-503-updater-progress-eta
luisguzman-adfa
force-pushed
the
feat/K2GO-503-updater-progress-eta
branch
from
October 22, 2026 20:30
abfbd3e to
40a8347
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Update add-ons and Update build assets updaters now show one
monotonic progress bar with aggregate speed and total ETA, a "Checking for
updates..." state, and a result that says whether the content was already up to
date or a new version was installed. The fix lives in the shared path, so the
add-ons/assets duplication is removed and a new download module inherits the
behavior.
How
downloadWithAria2aggregates progress across all files througharia2's RPC (piece-accurate
completedLength): overall percent, aggregatespeed, and total ETA on the job. Add-ons supplies the total from its staged
catalog; assets uses aria2's learned totals. aria2 is shut down on queue drain
(it does not exit on its own under RPC); the console readout stays as the
fallback. New
etafield throughjobs.ts/routes.ts. No mirror change.ContentUpdaterinterface + sharedContentUpdaterView(progressblock, checking state, percent/speed/ETA line, terminal
done/up-to-date/failed/cancelled, and the listener-lifecycle guard that fixes
the initial-paint race).
AddonsUpdater/CodeAssetsUpdaterare thinadapters; the duplicated
AddonsRefresh/CodeAssetsRefreshare deleted;ModuleActionsis rewired.engine's process kill, not RPC (RPC is read-only progress); the metered-network
consent stays app-side before the download. The withRetry reconnect indicator
is re-surfaced from the poller.
UI
The add-ons and build-assets module updaters (the inline progress under the
Update button). Light and dark + device verification pending.
Strings
New UI strings, localized to all 33 locales before merge:
k2go_update_checkingk2go_eta_min_seck2go_eta_seck2go_code_addons_update_up_to_datek2go_code_assets_update_up_to_dateVerification
tscgreen; appcompileStandardDebugJavaWithJavacgreen.