Skip to content

feat(federation): add env var for MAX_NON_LOCAL_SELECTIONS - #10349

Open
lrlna wants to merge 10 commits into
devfrom
lrlna/RH-1408
Open

lrlna wants to merge 10 commits into
devfrom
lrlna/RH-1408

change british english spelling

7c77228
Select commit
Loading
Failed to load commit list.
Apollo Librarian / AI Style Review succeeded Oct 1, 2026 in 9s

Style Review Completed

The pull request has 1 style issue.

Duration: 3774ms
PR URL: #10349
Review Log: View detailed log
Review Comments: The AI has posted 1 inline comment with suggestions

Summary of changes:

The documentation has been updated to improve clarity, directness, and grammatical consistency. In the 'framing-apollo-products', 'framing', and 'verb-tense-and-voice' sections, passive phrasing such as 'This is used to' has been replaced with the active, imperative 'Use' or standard present tense. The 'language' and 'word-and-symbol-usage' sections now include the missing preposition 'of' to enhance readability and grammatical flow. Additionally, the 'structural-elements' section was updated to ensure list items that are fragments do not end with punctuation.

鈿狅笍 This review and suggested changes are AI-generated. Please use common sense when accepting these suggestions, as they may not always be accurate or appropriate for your specific context.

Annotations

Check notice on line 198 in docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/standard-instruments.mdx

See this annotation in the file changed.

@apollo-librarian apollo-librarian / AI Style Review

docs/source/routing/observability/router-telemetry-otel/enabling-telemetry/standard-instruments.mdx#L198

**Framing Apollo Products**: Use 'Use' instead of 'This is used to' for more direct, colloquial language.

**Framing**: Use the imperative 'Use' instead of the passive 'This is used' to be more direct and reader-centric.

**Language**: Added 'of' to improve grammatical clarity.

**Structural Elements**: Omit ending punctuation for list items that are fragments.

**Verb Tense and Voice**: Use present tense instead of 'is used to'.

**Word and Symbol Usage**: The word 'of' is missing after 'number' for grammatical clarity, though not explicitly in the guide, the guide requires clear and readable text.

```suggestion
- `apollo.router.query_planning.plan.non_local_selections` - Histogram of the number non-local selections estimated during query planning traversal. Use this to optimize option exploration when planning an operation.
```