[ISSUE #299]polish(example) remove selection count - #310
Open
ni-ze wants to merge 1 commit into
Open
Conversation
ni-ze
changed the title
Contributor
Author
|
close #299 |
joeCarf
approved these changes
Sep 18, 2023
RockteMQ-AI
approved these changes
Jun 11, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review: Approved ✅
PR: #310 — Fix example
Type: Bug fix (1 file, +3/-3)
Assessment
Fixes example code. Minimal change.
Verdict
✅ Simple fix.
🤖 Automated review by oss-sentinel-ai
RockteMQ-AI
approved these changes
Aug 22, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
LGTM — Clean removal of unused count(SelectAction) overload, resetOffsetHandler field, and stale example.
Note: removing GroupedStream.count(SelectAction) is a breaking API change for downstream users. Consider mentioning this in release notes.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.