Skip to content

fix(pouchdb-errors): guard Error.stack access when stack is inaccessible #9193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mayankaggarwal8055 wants to merge 7 commits into
base: master
Choose a base branch
from
+9 −5
Open

fix(pouchdb-errors): guard Error.stack access when stack is inaccessible #9193

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
acc8cb1
fix(pouchdb-errors): guard Error.stack access when stack is inaccessible
Mayankaggarwal8055 Mar 6, 2026
96ba92d
fix(pouchdb-errors): guard stack access and avoid mutating UNKNOWN_ERROR
Mayankaggarwal8055 Mar 6, 2026
22dee90
Merge branch 'master' into fix/error-stack-handling
Mayankaggarwal8055 Mar 6, 2026
25c2f1e
Update packages/node_modules/pouchdb-errors/src/index.js
Mayankaggarwal8055 Apr 7, 2026
7b03723
Update packages/node_modules/pouchdb-errors/src/index.js
Mayankaggarwal8055 Apr 7, 2026
f4de330
Update index.js
Mayankaggarwal8055 Apr 7, 2026
9646402
wrap stack in try-catch
SourceR85 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions packages/node_modules/pouchdb-errors/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,12 @@ function createError(error, reason) {
pouchError[name] = error[name];
}

try {
void pouchError.stack;
} catch (e) {
// Silently ignore inaccessible stack
}

Comment thread
Mayankaggarwal8055 marked this conversation as resolved.
Outdated
if (reason !== undefined) {
pouchError.reason = reason;
}
Expand All @@ -70,9 +76,9 @@ function createError(error, reason) {
function generateErrorFromResponse(err) {

if (typeof err !== 'object') {
var data = err;
err = UNKNOWN_ERROR;
err.data = data;
const newErr = Object.assign({}, UNKNOWN_ERROR); // Clone to avoid mutation
newErr.data = err;
err = newErr;
Comment thread
Mayankaggarwal8055 marked this conversation as resolved.
Outdated
}

if ('error' in err && err.error === 'conflict') {
Expand All @@ -92,10 +98,6 @@ function generateErrorFromResponse(err) {
err.message = err.message || err.reason;
}

if (!('stack' in err)) {
err.stack = (new Error()).stack;
}

Comment thread
SourceR85 marked this conversation as resolved.
return err;
}

Expand Down