Catalog Migrator: Add missing BUNDLE-NOTICE and BUNDLE-LICENSE entries - #196
Conversation
|
This PR is for next release. |
|
Bumping the Iceberg version and polaris version for view support work. I will recheck this before the release. Keeping in draft. |
37224f6 to
f27801d
Compare
|
|
||
| ------------------------------------------------------------------------- | ||
|
|
||
| This artifact bundles Apache Iceberg with the following in its NOTICE: |
There was a problem hiding this comment.
Notice from Apache Iceberg.
|
|
||
| ------------------------------------------------------------------------- | ||
|
|
||
| This artifact bundles Snappy Java with the following in its NOTICE: |
f27801d to
f59a38c
Compare
| "META-INF/**/DISCLAIMER", | ||
| "LICENSE*", | ||
| "NOTICE*", | ||
| "THIRD-PARTY-NOTICES", |
There was a problem hiding this comment.
analyticsaccelerator-s3 dependency jar contains a root-level THIRD-PARTY-NOTICES file. After the exclusion, the final shadow jar only has curated META-INF/LICENSE and META-INF/NOTICE, which is cleaner for this bundle metadata PR.
f59a38c to
6932006
Compare
6932006 to
5ac282e
Compare
|
@dimas-b: PR is ready and it is as per the latest code. Once this is merged, I can cut a new release that supports view migration. |
| | Copyright 2014 The Apache Software Foundation | ||
| | | ||
| | This product includes software developed at | ||
| | The Apache Software Foundation (http://www.apache.org/). |
There was a problem hiding this comment.
nit: This is a standard ASF NOTICE. Since polaris-tools is also an ASF project, I do not think we have to repeat it.
There was a problem hiding this comment.
We have done this above. So, followed same pattern. Maybe we can have one separate clean up PR and get it reviewed once JB is back.
This artifact bundles reload4j with the following in its NOTICE:
| Apache log4j
| Copyright 2007 The Apache Software Foundation
|
| This product includes software developed at
| The Apache Software Foundation (http://www.apache.org/).
2 participants
Summary
BUNDLE-NOTICE entries added:
BUNDLE-LICENSE entry added:
org/iq80/leveldb/*(source)Test plan
./gradlew ratpasses./gradlew :iceberg-catalog-migrator-cli:shadowJarbuilds successfullyMETA-INF/NOTICEin the uber jar contains all new entries