Repository navigation
Update scala3-library to 3.3.9 - #1386
Merged
pjfanning merged 3 commits intoOct 28, 2026
Merged
Conversation
Motivation: Scala 3.3.9 emits more complete Java generic signatures than 3.3.8, so MiMa reports 127 IncompatibleSignatureProblems in http and http-core. Erased descriptors are unchanged, so runtime binary compatibility is unaffected. Modification: Add a MiMaSignatureProblems auto plugin that requires the sbt-pekko-build MiMa plugin (which sets mimaReportSignatureProblems := true) and overrides it to only report signature problems on Scala 2.13. Drop the setting from Common, which was applied before the sbt-pekko-build plugin and had no effect. Result: MiMa passes on Scala 3.3.9 without a large excludes file. Tests: - sbt "++3.3.9" http-core/mimaReportBinaryIssues http/mimaReportBinaryIssues: success - show mimaReportSignatureProblems: false on 3.3.9, true on 2.13 References: Refs apache/pekko#3538
Motivation: The validatePullRequest MiMa check calls SbtMima.runMima directly and skipped the mimaReportSignatureProblems filter that mimaReportBinaryIssues applies, so the Scala 3 build still failed on 127 IncompatibleSignatureProblems. Modification: Drop IncompatibleSignatureProblems from the reported problems when mimaReportSignatureProblems is false. Result: validatePullRequest passes on Scala 3.3.9; signature problems are still reported on Scala 2.13. Tests: - sbt "++3.3.9" "show http/mimaResult" "show http-core/mimaResult": NoErrors - sbt "show http/mimaResult" "show http-core/mimaResult" (2.13): NoErrors References: Refs apache/pekko#3538
He-Pin
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About this PR
📦 Updates org.scala-lang:scala3-library from
3.3.8to3.3.9📜 GitHub Release Notes - Version Diff - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: