Fixed: EntityExpr no longer hardcodes the "default" delegator when validating condition types (OFBIZ-5100)#1420
Merged
mridulpathak merged 1 commit intoJul 24, 2026
Conversation
…lidating condition types (OFBIZ-5100)
EntityExpr.checkRhsType() always resolved DelegatorFactory.getDelegator("default")
instead of using the delegator actually running the query, so any setup using a
non-"default"-named delegator could throw GenericEntityException when building a
WHERE clause. The real delegator was already available at every call site in
GenericDAO; it just wasn't being passed down.
Threads the real Delegator through EntityCondition.makeWhereString(...) as a new
backward-compatible default method, and forwards it through every condition type
that wraps or combines other conditions (EntityConditionList, EntityFieldMap,
EntityNotCondition, EntityConditionBuilder) down to EntityExpr.checkRhsType(),
which now skips RHS type validation instead of guessing at "default" when no
delegator is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: EntityExpr no longer hardcodes the "default" delegator when validating condition types
(OFBIZ-5100)
EntityExpr.checkRhsType() always resolved DelegatorFactory.getDelegator("default") instead of using the delegator actually running the query, so any setup using a non-"default"-named delegator could throw GenericEntityException when building a WHERE clause. The real delegator was already available at every call site in GenericDAO; it just wasn't being passed down.
Threads the real Delegator through EntityCondition.makeWhereString(...) as a new backward-compatible default method, and forwards it through every condition type that wraps or combines other conditions (EntityConditionList, EntityFieldMap, EntityNotCondition, EntityConditionBuilder) down to EntityExpr.checkRhsType(), which now skips RHS type validation instead of guessing at "default" when no delegator is available.
Thanks: Tarun Kumar for reporting the issue.