Skip to content

Fixed: Sanitize fetched page text in HttpViewHandler #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mridulpathak wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Fixed: Sanitize fetched page text in HttpViewHandler #1294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions framework/webapp/src/main/java/org/apache/ofbiz/webapp/view/HttpViewHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import org.apache.ofbiz.base.util.Debug;
import org.apache.ofbiz.base.util.HttpClient;
import org.apache.ofbiz.base.util.HttpClientException;
import org.apache.ofbiz.base.util.UtilCodec;
import org.apache.ofbiz.base.util.UtilValidate;
import org.apache.ofbiz.webapp.control.ConfigXMLReader;

Expand Down Expand Up @@ -67,8 +68,13 @@ public void render(String name, String page, String info, String contentType, St
HttpClient httpClient = new HttpClient(page);
String pageText = httpClient.get();

// TODO: parse page and remove harmful tags like <HTML>, <HEAD>, <BASE>, etc - look into the OpenSymphony piece for an example
response.getWriter().print(pageText);
// Sanitize the retrieved HTML content using the configured OFBiz HTML encoder/sanitizer
String sanitizedPageText = UtilCodec.getEncoder("html").sanitize(pageText, null);

// Explicitly enforce the standard OFBiz permissive HTML policy to guarantee XSS-safe markup rendering
sanitizedPageText = UtilCodec.HtmlEncoder.PERMISSIVE_POLICY.sanitize(sanitizedPageText);

response.getWriter().print(sanitizedPageText);
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
} catch (IOException e) {
throw new ViewHandlerException("IO Error in view", e);
} catch (HttpClientException e) {
Expand Down
Loading