Skip to content

FLUME-3327 add useKafkaHeader option to convert flume headers as kafk… #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stakafum wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

FLUME-3327 add useKafkaHeader option to convert flume headers as kafk… #280

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2624351
FLUME-3327 add useKafkaHeader option to convert flume headers as kafk…
stakafum Jun 30, 2017
dbc3773
fromatted
stakafum Apr 3, 2019
42c5cf8
bug fix to add charset to getByte()
stakafum Apr 4, 2019
ebb8cb6
bug fix
stakafum Apr 4, 2019
cd69e50
bug fix and formatted
stakafum Apr 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more

package org.apache.flume.sink.kafka;

import com.google.common.base.Charsets;
import com.google.common.base.Optional;
import com.google.common.base.Throwables;
import org.apache.avro.io.BinaryEncoder;
Expand Down Expand Up @@ -437,7 +438,7 @@ private void setProducerProps(Context context, String bootStrapServers) {
private Headers toKafkaHeaders(Map<String, String> headers) {
Headers kafkaHeaders = new RecordHeaders();
for (Entry<String, String> header : headers.entrySet()) {
kafkaHeaders.add(header.getKey(), header.getValue().getBytes());
kafkaHeaders.add(header.getKey(), header.getValue().getBytes(Charsets.UTF_8));

@slem1 slem1 Sep 3, 2019 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think expected Charsets should be configurable through flume context parameters

@tmgstevens tmgstevens Sep 27, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

}
return kafkaHeaders;
}
Expand Down