KNOX-3406: LDAP Proxy backend improve error handling - #1355
Open
handavid wants to merge 1 commit into
Open
Conversation
The LdapProxyBackend.getUser code was modified to ensure that the search cursor is closed before attempting to augment the entry with group memberships to avoid having simultaneously open cursors. The error handling in performPagedSearch was improved such that unsuccessful paging calls will result in exceptions for the caller to handle.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3406 - Fix LDAP Proxy error handling
What changes were proposed in this pull request?
The LdapProxyBackend.getUser code was modified to ensure that the search cursor is closed before attempting to augment the entry with group memberships to avoid having simultaneously open cursors.
The error handling in performPagedSearch was improved such that unsuccessful paging calls will result in exceptions for the caller to handle.
How was this patch tested?
Workflow was run repeatedly to try reproducing the intermittent failures in the JIRA. Through this, I discovered the paging issue that I've fixed in this PR. Unit tests were added to cover the paged search changes.
Integration Tests
no tests added
UI changes
no UI changes