Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Streaming stops prematurely when filtered manifests produce an empty batch before later matching manifests.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Refactors manifest planning around a shared PlanningContext and adds streaming regression tests.
Changes:
- Centralizes filtering, evaluator, and column projection logic.
- Simplifies eager and streaming planning paths.
- Adds batch-boundary and metrics-parity tests.
| File | Description |
|---|---|
src/iceberg/manifest/manifest_group.cc |
Refactored planning and streaming logic. |
src/iceberg/manifest/manifest_group.h |
Added planning context declarations and updated helpers. |
src/iceberg/test/manifest_group_test.cc |
Added stream and metrics tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.