test(spark): extend Spark 4 variant shredding coverage - #19403
Open
yihua wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19403 +/- ##
============================================
+ Coverage 72.49% 74.48% +1.98%
+ Complexity 32888 32194 -694
============================================
Files 2574 2574
Lines 149010 142978 -6032
Branches 18749 17584 -1165
============================================
- Hits 108032 106498 -1534
+ Misses 32513 28462 -4051
+ Partials 8465 8018 -447
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Collaborator
yihua
marked this pull request as ready for review
July 30, 2026 19:29
hudi-agent
reviewed
Jul 30, 2026
hudi-agent
left a comment
hudi-agent
left a comment
Contributor
There was a problem hiding this comment.
No reviewable code files in this PR.
cc @yihua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
Spark4VariantShreddingProvider(the AVRO read-path bridge to Spark 4's variant shredding writer) was only lightly covered (~32%). Most scalar leaf types, the residual/partial-shredding paths, the decimal on-disk decodings, and the null/error guards had no test exercising them.Summary and Changelog
Extends the existing
TestSpark4VariantShreddingProvider(no new test class) with cases that pin behavior, not just non-null, on the previously uncovered shapes:avroTypeToScalarType/convertScalarToAvro: int, long, float, double, string, boolean, binary (bytes and FIXED), UUID, date, timestamp-micros, local-timestamp-micros, decimal. Each asserts the exacttyped_valueproduced, that there is no residualvalue, and that the variant round-trips.avroTypeToScalarTypereturns null for), assertingtyped_valuestays null andvalueis populated.value+ nulltyped_value) and an extra variant field captured in the top-level residualvalue.rebuild(aByteBufferfor bytes-backed and aGenericFixedfor fixed-backed decimals), plus theIllegalStateExceptionon an unexpected decimal representation.shredVariantRecordreturning null whenvalue/metadatais missing,rebuildVariantRecordreturning null for a null record, and theHoodieExceptionthrown when the requiredmetadatais missing.Impact
None. Test-only change.
Risk Level
none
Documentation Update
none
Contributor's checklist