fix(flink): improve clustering resource cleanup and coverage - #19400
Merged
danny0405 merged 1 commit intoJul 30, 2026
Conversation
cshuo
force-pushed
the
flink-clustering-compaction-coverage
branch
2 times, most recently
from
July 29, 2026 02:22
06bd669 to
f239f45
Compare
cshuo
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19400 +/- ##
============================================
+ Coverage 72.19% 73.64% +1.44%
- Complexity 32595 32815 +220
============================================
Files 2561 2574 +13
Lines 148328 146111 -2217
Branches 18654 18147 -507
============================================
+ Hits 107087 107605 +518
+ Misses 32774 30416 -2358
+ Partials 8467 8090 -377
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
cshuo
force-pushed
the
flink-clustering-compaction-coverage
branch
from
July 29, 2026 03:02
f239f45 to
b3cde65
Compare
cshuo
marked this pull request as ready for review
July 29, 2026 03:08
hudi-agent
reviewed
Jul 29, 2026
hudi-agent
left a comment
hudi-agent
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on this! This PR adds Flink operator-harness and unit tests for the clustering operator, clustering commit sink, consistent-bucket update strategy, and compaction plan source function, with no production code changes. No correctness issues found. A few style/readability suggestions in the inline comments. Please take a look, and this should be ready for a Hudi committer or PMC member to take it from here. One minor naming nit in the test helper; the rest of the code is clean and well-structured.
cc @yihua
danny0405
reviewed
Jul 29, 2026
danny0405
left a comment
danny0405
left a comment
Contributor
There was a problem hiding this comment.
The success paths look covered, but the new clustering tests expose an exception-path resource leak that should be addressed.
cshuo
force-pushed
the
flink-clustering-compaction-coverage
branch
from
July 29, 2026 07:18
b3cde65 to
ab583a6
Compare
Close clustering readers, sorters, and writers on failures to prevent resource leaks in long-running Flink tasks. Expand coverage for the clustering operator, clustering commit sink, compaction plan source function, and consistent bucket update strategy. Addresses review comment 3670917473.
cshuo
force-pushed
the
flink-clustering-compaction-coverage
branch
from
July 29, 2026 07:22
ab583a6 to
0b65db5
Compare
cshuo
changed the title
github-actions
Bot
added
size:XL
danny0405
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
Closes #19397.
The Flink clustering and compaction operators and the consistent-bucket update strategy had low or missing unit-test coverage. The standalone job drivers remain integration-test-only and are tracked separately by ENG-44609 because that coverage is not currently uploaded.
Summary and Changelog
Local JaCoCo line coverage from the targeted suite:
ClusteringOperatorClusteringCommitSinkFlinkConsistentBucketUpdateStrategyCompactionPlanSourceFunctionImpact
No public API or user-facing behavior changes. This PR only adds tests.
Risk Level
Low. Production code is unchanged.
Validation
The targeted Maven and JaCoCo-instrumented test runs completed successfully:
Checkstyle and RAT also passed.
Documentation Update
None.
Contributor's checklist