Skip to content

HIVE-29397: Apply masking to TestBeeLineDriver qtest goldens when overwrite enabled #6609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyanzheng2926 wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

HIVE-29397: Apply masking to TestBeeLineDriver qtest goldens when overwrite enabled #6609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,9 +237,10 @@ private void runTest(QFile qFile, List<Callable<Void>> preCommands) throws Excep
long filterEndTime = System.currentTimeMillis();
System.err.println(">>> FILTERED " + qFile.getName() + ": " + (filterEndTime - queryEndTime)
+ "ms");
qOutProcessor.maskPatterns(qFile.getOutputFile().getPath());

@thomasrebele thomasrebele Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extraneous linebreak on line 241.


if (!overwrite) {
qOutProcessor.maskPatterns(qFile.getOutputFile().getPath());
QTestProcessExecResult result = qFile.compareResults();

long compareEndTime = System.currentTimeMillis();
Expand Down
Loading