[FLINK-38262][table] alter connection rename operation#28793
Open
Shekharrajak wants to merge 4 commits into
Open
[FLINK-38262][table] alter connection rename operation#28793Shekharrajak wants to merge 4 commits into
Shekharrajak wants to merge 4 commits into
Conversation
Shekharrajak
force-pushed
the
FLINK-38262-alter-connection-rename-operation
branch
from
July 21, 2026 17:27
9b6de7f to
159e39c
Compare
snuyanzin
requested changes
Jul 21, 2026
snuyanzin
left a comment
snuyanzin
left a comment
Contributor
There was a problem hiding this comment.
Please do not ignore Contributors form
Generated-by: Codex (GPT-5)
Shekharrajak
force-pushed
the
FLINK-38262-alter-connection-rename-operation
branch
from
July 22, 2026 04:54
159e39c to
1fdc876
Compare
Contributor
Author
|
@flinkbot run azure |
raminqaf
reviewed
Jul 27, 2026
raminqaf
left a comment
raminqaf
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution! Left some comments
Comment on lines
+1044
to
+1063
| /** | ||
| * Rename an existing connection. | ||
| * | ||
| * @param connectionPath Path of the connection to be renamed | ||
| * @param newConnectionName the new name of the connection | ||
| * @param ignoreIfNotExists Flag to specify behavior when the connection does not exist: if set | ||
| * to false, throw an exception, if set to true, do nothing. | ||
| * @throws ConnectionNotExistException if the connection does not exist | ||
| * @throws ConnectionAlreadyExistException if a connection with the new name already exists | ||
| * @throws CatalogException in case of any runtime exception | ||
| */ | ||
| default void renameConnection( | ||
| ObjectPath connectionPath, String newConnectionName, boolean ignoreIfNotExists) | ||
| throws ConnectionNotExistException, ConnectionAlreadyExistException, CatalogException { | ||
| throw new UnsupportedOperationException( | ||
| String.format( | ||
| "renameConnection(ObjectPath, String, boolean) is not implemented for %s.", | ||
| this.getClass())); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Is the community aligned with adding this to the public API? I haven't seen a Mailing Thread or FLIP on this. Maybe I have missed it.
Contributor
There was a problem hiding this comment.
Moreover, in the PR description you mentioned:
The public API, i.e., is any changed class annotated with
@Public(Evolving): (yes / no) no
Which is not the case here
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
…k/table/catalog/CatalogManager.java Co-authored-by: Ramin Gharib <ramingharib@gmail.com>
…k/table/catalog/CatalogManager.java Co-authored-by: Ramin Gharib <ramingharib@gmail.com>
snuyanzin
reviewed
Jul 27, 2026
Comment on lines
+98
to
+99
| tEnv().executeSql("CREATE TEMPORARY CONNECTION my_conn WITH ('k' = 'v')"); | ||
| tEnv().executeSql("CREATE TEMPORARY CONNECTION new_conn WITH ('k' = 'v')"); |
Contributor
There was a problem hiding this comment.
what will happen if there is a temporary connection and we create a non temporary connection?
and vice versa?
github-actions
Bot
added
the
community-reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Adds ALTER CONNECTION ... RENAME TO conversion/execution, catalog rename support, temporary connection rename handling, and catalog/runtime tests.
Brief change log
Add ALTER CONNECTION RENAME operation
Verifying this change
Unit tests and IT
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no) yesDocumentation
Was generative AI tooling used to co-author this PR?