perf: remove per-row String allocation from Spark soundex and quote

[andygrove]

Which issue does this PR close?

N/A

Rationale for this change

Spark's soundex and quote both allocated a fresh String for every row and
collected the results into a StringArray.

soundex allocated twice per row: once for the code buffer, and again for the
format!("{soundex_code:0<4}") that zero-pads it. quote allocated a String
sized to the input, then copied the input into it one char at a time.

Neither function needs to allocate per row. A soundex code is always exactly
four ASCII characters, so it fits in a stack buffer. quote only ever wraps the
input and escapes embedded quotes, so it can write straight into the output
buffer and copy the runs between quotes rather than character by character.

What changes are included in this PR?

soundex.rs:

• compute_soundex(&str) -> String becomes append_soundex(&mut StringBuilder, &str),
  building the four-character code in a [u8; 4] initialised to b'0' — which is
  the zero-padding, so the trailing format! disappears.
• Strings that do not start with an ASCII letter are passed through unchanged;
  previously this path called s.to_string(), now it appends by reference.
• The Utf8/LargeUtf8 and Utf8View entry points share one soundex_impl
  over Option<&str>, pre-sizing the builder at 4 bytes per row.

quote.rs:

• compute_quote(&str) -> String becomes append_quoted(&mut StringBuilder, &str),
  writing into the builder's buffer via the fmt::Write impl and finalising with
  append_value("").
• Escaping uses str::split('\'') to copy the runs between quotes in one memcpy
  each, instead of pushing every char individually.
• The builder is pre-sized from the input's value_data() length plus two bytes
  per row for the surrounding quotes.

Output is unchanged in both cases.

Are these changes tested?

Existing coverage pins the behaviour: spark/string/soundex.slt and
spark/string/quote.slt assert concrete outputs, including the non-alphabetic
passthrough, codes shorter than four characters (padding), codes truncated at
four, and strings with and without embedded quotes. All 59 spark/string
sqllogictest files and the 258 datafusion-spark unit tests pass.

The benchmark used below, datafusion/spark/benches/soundex_quote.rs, is added
separately in #23882 so the baseline can be measured on main before this
change lands. It covers both functions over Utf8 and Utf8View at 1024 and
8192 rows with 20% nulls; the quote input is a mix of strings with and without
embedded quotes so the escaping path is exercised without dominating.

Benchmarks

Criterion, apache/main @ f1ab86dad as baseline. Median of the reported
change interval.

Benchmark	1024	8192
soundex/utf8	−52.9%	−49.5%
soundex/utf8view	−54.5%	−50.2%
quote/utf8	−60.7%	−61.5%
quote/utf8view	−60.5%	−61.3%

Are there any user-facing changes?

No. Both functions produce byte-identical output; this is purely an allocation
change.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 89.79592% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.67%. Comparing base (f1ab86d) to head (4a7577f).
⚠️ Report is 21 commits behind head on main.

Files with missing lines	Patch %	Lines
datafusion/spark/src/function/string/soundex.rs	85.71%	2 Missing and 1 partial ⚠️
datafusion/spark/src/function/string/quote.rs	92.85%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #23880      +/-   ##
==========================================
+ Coverage   80.65%   80.67%   +0.02%     
==========================================
  Files        1091     1095       +4     
  Lines      371031   372468    +1437     
  Branches   371031   372468    +1437     
==========================================
+ Hits       299256   300495    +1239     
- Misses      53935    54041     +106     
- Partials    17840    17932      +92     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[neilconway]

Overall looks reasonable!

[neilconway]

str_array.value_data().len() will over-allocate for sliced arrays.

[andygrove]

Confirmed — GenericByteArray::slice clones the whole value_data buffer and narrows only the offsets, so this over-allocates by however much of the buffer the slice excludes. Now taking the length from the sliced offsets (last - first) in 4a7577f.

[neilconway]

Looks like get_buffer_memory_size sums the buffer capacities, not their actual valid contents, so this will also over-allocate for sliced arrays.

[andygrove]

Right, and it is wrong in the other direction too: strings of 12 bytes or fewer live inline in the views, so the data buffers can be near-empty while the array holds plenty of data. Switched to total_bytes_len(), which walks the sliced views and counts inlined values, in 4a7577f.

[Jefffrey]

offset buffers are guaranteed to be non-empty so we can unwrap instead of matching here