Repository navigation
Conversation
Add corresponding tests
Member
Author
|
Just a remark: The whole DocumentName seems to be a bit over engineered. Just relying on java.nio.Path and leveraging its resolve would have been much better in my perspective instead of reimplementing this in https://github.com/kwin/creadur-rat/blob/8102159b4f38851a00c11d73c25a2925ef498bfe/apache-rat-core/src/main/java/org/apache/rat/document/DocumentName.java#L164. |
Contributor
|
Thanks for providing a patch to the problem - @Claudenw do you see any problem with the change? |
ottlinger
approved these changes
Oct 29, 2026
ottlinger
left a comment
ottlinger
left a comment
Contributor
There was a problem hiding this comment.
I'm okay with the change so far. Thanks again for your help.
The change in the changes.xml is minor, thus my approval albeit a tiny wish for this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add corresponding tests